From: ChiYuan Huang <cy_huang@richtek.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Otto Lin <otto_lin@richtek.com>,
Allen Lin <allen_lin@richtek.com>, <linux-sound@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: dt-bindings: maxim,max98357a: Add compatible with richtek,rt9123
Date: Tue, 18 Mar 2025 19:26:14 +0800 [thread overview]
Message-ID: <Z9lYVram80dbWWl0@git-send.richtek.com> (raw)
In-Reply-To: <20250318-mature-dogfish-of-ecstasy-3dcea5@krzk-bin>
On Tue, Mar 18, 2025 at 09:55:48AM +0100, Krzysztof Kozlowski wrote:
> On Tue, Mar 18, 2025 at 08:57:51AM +0800, cy_huang@richtek.com wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > The hardware control and specification of 'richtek,rt9123' are similar
> > with max98357 or max98360. It's no need to add the new source code. So
>
> Are you sure? I looked at datasheet and do not see anything about
> SD_MODE in RT9123. Also you have two supplies, while max98360a has only
> one. You have I2C but max98360a has no.
>
Sure, consider the I2C mode. Then it seems different. For the power
supply, yes, we have one more supply and it's used for digital input
output reference. It will always tiled to SoC digital power domain.
It's no need to control, so I think DVDD can be ignored.
If not considering the I2C, and the DVDD power supply, for HW control
mode, then it looks the same including sample rate. One pin to turn on
the amplifier.
This IC is designed for 'easy to use'. For the normal condition, HW mode
will always be suggested to the customer.
May I have your suggestion? If it can not be compatible, should I write
two drivers, one platform driver for HW control mode, and another I2C driver
for I2C SW control mode?
Hope to get your feedback.
Sincerely,
ChiYuan Huang.
> These devices do not look compatible.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2025-03-18 11:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 0:57 [PATCH] ASoC: dt-bindings: maxim,max98357a: Add compatible with richtek,rt9123 cy_huang
2025-03-18 8:55 ` Krzysztof Kozlowski
2025-03-18 11:26 ` ChiYuan Huang [this message]
2025-03-19 7:42 ` Krzysztof Kozlowski
2025-03-19 8:21 ` ChiYuan Huang
2025-03-19 8:36 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9lYVram80dbWWl0@git-send.richtek.com \
--to=cy_huang@richtek.com \
--cc=allen_lin@richtek.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=otto_lin@richtek.com \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox