From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 469A1801 for ; Wed, 19 Mar 2025 05:41:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742362893; cv=none; b=tytdQ0XccBKSKoh1iwLAKPBXsXrKMqWOkTqGs87cbcCBcv4/dX2jSDE5KljMEXgBxMwR02MYz12AYnQIbGJA3HnNSzexSp3a7BvbWTT75yHNHbEO5OOK/Z3a67yaWhhFOKsCtTUdHnQs42cciga3sZSPJcN55454cPEtR7gZUSY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742362893; c=relaxed/simple; bh=zajX4u1rvXE4OGGWMMU4XmmhOmdpr20GoaCEs1zo6X0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=WUePjS7LttHupqQwuyYih59AibOSy6jFOYzHuvLXuD1HmFq3AfZBJIoeYbYk6R2+zi2z2oSXNGQgg6CMs3T+BlLW5Z+ve/PrNb+v85M49YlWCeSI6Oc0tjtix4ZDEPCAcXlYq80J29+t4ibA/7Bp4bIrRNNAFTL/b2KR7ZRw4og= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=ALhTHa8h; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="ALhTHa8h" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=zajX 4u1rvXE4OGGWMMU4XmmhOmdpr20GoaCEs1zo6X0=; b=ALhTHa8h3DlTx3MdXu4y mo7lH4H/OWwS9SVJuADqLUbn9pGNHV+jB/bukwXe7sYMnBajNXxBACPI6KhPKdxd +ns9jqfsnurm4HnAPs7Zst2TfklJ0Ctqn4XnHfiDJt52YnqKEFgjkzee7DghtAcW xRsw/Uhp1KVRW7e8M0k52BjxQXu19JOkGhdg9OB1wTyjRCSHWNQZrF5SNjeNSaW0 7gMKLSt/8Aw7FmnNM2AiIE0++5Ud3AMWQYvfqUCG35WkgvoddOiQSrob9H51A7In gXiZ+JL1dptXqj1fY6dRzdOfC3OTvIWtH+Pbi3Q3k/1ec0ZUbw0M8JGZErRM4gFK SA== Received: (qmail 4162999 invoked from network); 19 Mar 2025 06:41:25 +0100 Received: by mail.zeus03.de with UTF8SMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 19 Mar 2025 06:41:25 +0100 X-UD-Smtp-Session: l3s3148p1@QVLVeKswsN0ujnsn Date: Wed, 19 Mar 2025 06:41:24 +0100 From: Wolfram Sang To: Andi Shyti Cc: Aryan Srivastava , Andy Shevchenko , Markus Elfring , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Richter Subject: Re: [PATCH v13 2/3] i2c: octeon: remove 10-bit addressing support Message-ID: Mail-Followup-To: Wolfram Sang , Andi Shyti , Aryan Srivastava , Andy Shevchenko , Markus Elfring , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Richter References: <20250318021632.2710792-1-aryan.srivastava@alliedtelesis.co.nz> <20250318021632.2710792-3-aryan.srivastava@alliedtelesis.co.nz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="JiybpNjJpgWhiUFQ" Content-Disposition: inline In-Reply-To: --JiybpNjJpgWhiUFQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > The datasheet I have isn't very clear on this part. Also, I'd > like to know if there's any product line that could be negatively > impacted by this patch. In my whole I2C life, I have neither seen a target supporting 10-bit addressing nor a a system that uses 10-bit addressing. I am even tempted to remove support from the kernel omce in a while. If the support is broken in this driver, it can be removed. A working version (if possible) can be added again by someone who needs it. I am taking bets it will be "never". Besides, the driver never set I2C_FUNC_10BIT_ADDR, so it really shouldn't have been used anywhere. Reviewed-by: Wolfram Sang --JiybpNjJpgWhiUFQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmfaWQEACgkQFA3kzBSg KbagLw//Qlh431hsi7/QTKpLTCN0tg8WufkOB90sehndWCI7cFEHs5Rfn7SNShby 6s2q6sP3I3Cu1+LpVgSZThLXGKX382yIwXEzM9vdLtH5E0tjAfKeiGF57N+mq62G y5JzmKCdtcEAgOrJewmF6p96eEu0oSS/IKHCVudyN9k0bfn/tGrM65+Mw8A3Xne4 FAqJh2sCnK2F5NkazGzdcPb/2R8TjBVGixlurlx97skXIjv4huRbUnCO7RZ39Hdi br//bSPhhS00QUaUDJR9L2mBv6DK2Fg+8khAjVEKCb4fQpILJ5JALjsgKVaHGW3l NhJCdZG1j53ilDYDLriyZiINheSmh5g1M74gjwAE0D232dd1zfefOjfu6558PySL LfRyS7lBICEtM9Wt0fdUl5Sc3Va7Xi36xNLqLb/HzRunIGh6Vf3nLFFrRZ1zS3Bc ct9+5+p41Xp4bYkajviE3TfJVyXt2KfPT9kh+l4lbtLcVAofH6gGyoytV7OUDn9L TPpGbVl2pHUXSvmkgBl3qhJKOL/+kLxbnqUx7gp8RuCr18woTYyOBaJ93NvzC4K7 QHlu2O1dPNniojkodNw624fYzEGHr5DWLTy8/oQEdDTX5nkW19l2P0pizdbic+we 47JBZs5Vv44MEcriAgbRquN9KggyXM0jAxnBkM51RpRJF68IYpw= =Zew5 -----END PGP SIGNATURE----- --JiybpNjJpgWhiUFQ--