From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Kees Cook <kees@kernel.org>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
linux-iio@vger.kernel.org, chrome-platform@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2][next] iio: cros_ec: Avoid -Wflex-array-member-not-at-end warning
Date: Wed, 19 Mar 2025 09:13:45 +0000 [thread overview]
Message-ID: <Z9qKyZsH4akWG2q3@google.com> (raw)
In-Reply-To: <202503180840.77F2F47DE8@keescook>
On Tue, Mar 18, 2025 at 08:42:41AM -0700, Kees Cook wrote:
> > + ((struct ec_params_get_cmd_versions *)buf->data)->cmd = cmd;
> > +
> > + ret = cros_ec_cmd_xfer_status(ec_dev, buf);
> > if (ret >= 0)
> > - *mask = buf.resp.version_mask;
> > + *mask = ((struct ec_response_get_cmd_versions *)buf->data)->version_mask;
> > return ret;
> > }
>
> Since "params" is used twice, I'd say do like the other patch and assign
> it to a new variable:
>
> struct ec_response_get_cmd_versions *params = buf->data;
> ...
> params->cmd = cmd;
> ...
> *mask = params->version_mask;
Not a pushback for introducing new variables. FWIW, it uses "param" and
"response" only once.
next prev parent reply other threads:[~2025-03-19 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 10:03 [PATCH v2][next] iio: cros_ec: Avoid -Wflex-array-member-not-at-end warning Gustavo A. R. Silva
2025-03-18 15:42 ` Kees Cook
2025-03-19 9:13 ` Tzung-Bi Shih [this message]
2025-03-30 18:11 ` Jonathan Cameron
2025-03-19 9:14 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9qKyZsH4akWG2q3@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=jic23@kernel.org \
--cc=kees@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox