From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miaoqian Lin <linmq006@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: Fix reference count leak in slave_show()
Date: Wed, 19 Mar 2025 12:45:03 +0200 [thread overview]
Message-ID: <Z9qgL357o5bfzQfm@smile.fi.intel.com> (raw)
In-Reply-To: <Z9qgENjcGFF-rDJe@smile.fi.intel.com>
On Wed, Mar 19, 2025 at 12:44:33PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 19, 2025 at 11:23:04AM +0800, Miaoqian Lin wrote:
...
> > struct device *child;
> > + int ret;
> >
> > child = device_find_any_child(&ctlr->dev);
> > - return sysfs_emit(buf, "%s\n", child ? to_spi_device(child)->modalias : NULL);
> > + ret = sysfs_emit(buf, "%s\n", child ? to_spi_device(child)->modalias : NULL);
> > + put_device(child);
> > +
> > + return ret;
>
> Can be written better in case of NULL:
>
> child = device_find_any_child(&ctlr->dev);
> if (child)
> return sysfs_emit(buf, "%s\n", child ? to_spi_device(child)->modalias);
Of course this has to be
return sysfs_emit(buf, "%s\n", to_spi_device(child)->modalias);
>
> put_device(child);
> return sysfs_emit(buf, "%s\n", NULL);
>
> No variable needed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-19 10:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 3:23 [PATCH] spi: Fix reference count leak in slave_show() Miaoqian Lin
2025-03-19 8:19 ` Geert Uytterhoeven
2025-03-19 10:44 ` Andy Shevchenko
2025-03-19 10:45 ` Andy Shevchenko [this message]
2025-03-19 10:45 ` Andy Shevchenko
2025-03-19 11:17 ` Greg Kroah-Hartman
2025-03-19 17:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9qgL357o5bfzQfm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=linmq006@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).