Re: [PATCH 1/5] dt-bindings: connector: add fixed-batteries property

Krzysztof Kozlowski
2025-03-16T16:55:19Z

On 15/03/2025 01:56, Amit Sunil Dhamne wrote:
> The intent of the patchset & this change is for the USB Type C protocol
> manager module (that consumes these bindings) to be able to get info
> (such as State of charge, design capacity, etc) from drivers that manage
> the battery/batteries in the system. In order for such info to propagate
> I need to hook up the references of these battery manager devices (fuel
> guages, etc.) to connector.
>
> I have addressed the connector <-> battery question in the cover letter.
>
>
>> If you mean chargers, the OF graph is already there for this and no need
>> for this patch.
>
> No I don't mean just chargers in this case. Also, I didn't follow you on
> the OF graph. Please can you explain further?
>
You are duplicating existing bindings and existing practice of
describing the actual connections via OF graph. And the binding already
has the OF graph. What to explain more? Please open the binding and look
at the ports. Maybe they are incomplete? Look how other USB and USB
Type-C connections are represented.

Best regards,
Krzysztof