Re: [PATCH 0/5] Add support for Battery Status & Battery Caps AMS in TCPM

Krzysztof Kozlowski
2025-04-03T08:02:36Z

On 03/04/2025 10:00, Krzysztof Kozlowski wrote:
>>>>>
>>>>> Which upstream DTS (or upstream supported hardware) is going to use this
>>>>> binding, so I can see how you are going to implement it there in the
>>>>> entire system?
>>>> This is for maxim,max33359 Type-C controller.
>>> Stop deflecting the questions. max33359 is not a board. I already asked
>>> two times.
>>>
>>> Apparently admitting "no upstream users" is impossible, so let's state
>>> the obvious:
>>>
>>> There are no upstream users of this.
>>
>> max33359 controller has an upstream user i.e., gs101-oriole (Pixel 6)
>> board. Totally agree that at the moment there are no upstream
>> devices/drivers for the Fuel Gauge (that my patchset has a dependency
>> on) in gs101-oriole board. gs101-oriole uses max77759 fuel gauge device.
>> I see that there's an effort for upstreaming it
>> (https://lore.kernel.org/all/20250102-b4-gs101_max77759_fg-v2-0-87959abeb7ff@uclouvain.be/).
>> I will mark my patches as dependent on it + demonstrate the relationship
>> of the devices in the gs101-oriole board. Hope that's okay?
>
> Then please send the DTS for GS101 Oriole using this binding. I don't
> understand the point of adding binding for some user and in the same
> time not doing anything for that user.

... and just a reminder: DTS goes to separate patchset (!) from USB
drivers one, with lore link in changelog or cover letter to the binding.

Best regards,
Krzysztof