Re: [PATCH v2] drm/nouveau: prime: fix ttm_bo_delayed_delete oops

[Danilo Krummrich <dakr@kernel.org>]

On Wed, Mar 19, 2025 at 03:06:52PM +0100, Christian König wrote:
> Am 19.03.25 um 14:04 schrieb Danilo Krummrich:
> 
> >> Signed-off-by: Chris Bainbridge <chris.bainbridge@gmail.com>
> >> Co-Developed-by: Christian König <christian.koenig@amd.com>
> > Then also Christian's SoB is required.
> 
> I only pointed out which two lines in nouveau need to move to fix this.
> 
> All the credit to figuring out what's wrong go to Chris, but feel free to add my SoB if required.

Then maybe Suggested-by: is the tags that fits best. :)

> 
> >
> >> Fixes: https://gitlab.freedesktop.org/drm/amd/-/issues/3937
> > This is a bug report from amdgpu, but I understand that the same issue applies
> > for nouveau.
> 
> The crash in amdgpu was caused by nouveau incorrectly dropping a DMA-buf reference while it was still needed.

Oh, I see.

> 
> Took us a while to figure that out, we could update the tags in the bug report but I think at this point it's unnecessary.

Agreed.

> 
> >
> > If at all, this needs to be
> >
> > 	Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3937
> >
> > Maybe you can add a brief comment that this report applies for nouveau as well.
> >
> > Please also add a Fixes: tag that indicates the commit in nouveau that
> > introduced the problem and Cc stable.
> 
> As far as I can see it was always there and was added >10years ago with the very first DMA-buf support.
> 
> But adding CC stable is a really good idea.

Sounds good.