From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5FCE213245 for ; Thu, 20 Mar 2025 08:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742461175; cv=none; b=ruIIMlK5LTVgtYolWhhiSL68bqboFtNJGMYBRkg6biVojlicgA5Fn6A4GMAARJUg++k7derJdyOJaDPDR+oDEycvxQtfiWYgTB+3o2sutoZoOKDLW3gcdoSTFKl8hqNVnQT4Q+y2CBRFa3PcktAIIb3lYCCxAV7wXitcAMVRwAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742461175; c=relaxed/simple; bh=xEK8S5NZZN0srSXWfnFdrZtCwFS9xhoDzVumA0xsMvc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BzU8+GwZgUue4kWc1Wtjp/8oQqGLWxKnChIq7GoJIyLWUYkVGfGlUJueiTc6KSg3SOmi/PAcykTc7EfVZQZQ96sTFiEMWaKEQa/ofAS9a+3ZLcRlrF1rEr/CVsdR/MvHfuwJtHVIV9p2tY6DgcysjsyX9/g+BN9bHHtAZ1K4cQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=unbtsvZd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="unbtsvZd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9C240C4CEDD; Thu, 20 Mar 2025 08:59:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742461174; bh=xEK8S5NZZN0srSXWfnFdrZtCwFS9xhoDzVumA0xsMvc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=unbtsvZduzn/wwWsYZ0/KuBAD2EISYzZCOlPTWe/+neTapvDJH5kEuWnMlnuP9a+p rmf0J7TI6LwBKVDWXj2zYKC0diP2YvQOLy+4D6YXGKffv4kE0Dvrio+273XUal4ZId BX2GFqomNFQKrWgtPTy6xYqzk5+xVnKPFJ0UgKwaypS71sfAERc4P7VmhrvbaBnO3o r9QeAKRW5+urlTJWT3WeNUtOWIR1jqPE1g7FJWThs1EZ36eyf0GRGzq7cPYfk3tnPc KMcGCkQ/ctsC3CJ4UtuNlUJoIKf/Me9vkzd4OoVQykdRkP2jOkixRN8A9kQPO3ny8V rTuwb/kGGWCmg== Date: Thu, 20 Mar 2025 09:59:28 +0100 From: Ingo Molnar To: Uros Bizjak Cc: Linus Torvalds , "H. Peter Anvin" , linux-kernel@vger.kernel.org, Juergen Gross , Stefano Stabellini , "Ahmed S . Darwish" , Andrew Cooper , John Ogness , Peter Zijlstra , Borislav Petkov , Thomas Gleixner , Josh Poimboeuf Subject: Re: [PATCH] compiler/gcc: Make asm() templates asm __inline__() by default Message-ID: References: <20250317221824.3738853-1-mingo@kernel.org> <5A417EE0-8DF3-4C6E-A7E9-9EE6705282F1@zytor.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: * Uros Bizjak wrote: > > > > I haven't looked at code generation much yet, but text size changes are > > > > minimal: > > > > > > > > text data bss dec hex filename > > > > 29429076 7931870 1401196 38762142 24f769e vmlinux.before > > > > 29429631 7931870 1401200 38762701 24f78cd vmlinux.after > > > > > > > > Which is promising, assuming I haven't messed up anywhere. > > > > > > Please use bloat-o-meter, it is more precise. > > > > Here's the bloat-o-meter output between vanilla and patched vmlinux: > > [...] > > > A lot fewer functions are affected than I expected from such a > > large-scope change. > > Interestingly, I got *many* more changes just from converting atomic > locking functions to asm_inline, as reported in [1]. > > [1] https://lore.kernel.org/lkml/CAFULd4YBcG45bigHBox2pu+To+Y5BzbRxG+pUr42AVOWSnfKsg@mail.gmail.com/ Have you used a pristine x86-64 defconfig for your build tests? Could you perhaps check my patch against your patch in your build environment and figure out why there's such unexpected differences? As you noted my patch should be a blunt-instrument superset of your changes so if then it should affect *more* functions, not fewer. Thanks, Ingo