Re: [PATCH v11 6/8] MAINTAINERS: rust: Add new sections for DELAY/SLEEP and TIMEKEEPING API

Andreas Hindborg
2025-03-22T22:40:49Z

Hi All,

"Boqun Feng" <boqun.feng@gmail.com> writes:

> On Sat, Mar 22, 2025 at 11:07:03AM +0900, FUJITA Tomonori wrote:
>> Thank you all!
>>
>> On Fri, 21 Mar 2025 14:00:52 -0700
>> Boqun Feng <boqun.feng@gmail.com> wrote:
>>
>> > On Fri, Mar 21, 2025 at 09:38:46PM +0100, Thomas Gleixner wrote:
>> >> On Fri, Mar 21 2025 at 20:18, Andreas Hindborg wrote:
>> >> >> Could you add me as a reviewer in these entries?
>> >> >>
>> >> >
>> >> > I would like to be added as well.
>> >>
>> >> Please add the relevant core code maintainers (Anna-Maria, Frederic,
>> >> John Stultz and myself) as well to the reviewers list, so that this does
>> >> not end up with changes going in opposite directions.
>> >>
>> >
>> > Make sense, I assume you want this to go via rust then (althought we
>> > would like it to go via your tree if possible ;-))?
>>
>
> Given Andreas is already preparing the pull request of the hrtimer
> abstraction to Miguel, and delay, timekeeping and hrtimer are related,
> these timekeeping/delay patches should go via Andreas (i.e.
> rust/hrtimer-next into rust/rust-next) if Thomas and Miguel are OK with
> it. Works for you, Andreas? If so...
>
>> Once the following review regarding fsleep() is complete, I will submit
>> patches #2 through #6 as v12 for rust-next:
>>
>> https://lore.kernel.org/linux-kernel/20250322.102449.895174336060649075.fujita.tomonori@gmail.com/
>>
>> The updated MAINTAINERS file will look like the following.
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index cbf84690c495..858e0b34422f 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -10370,6 +10370,18 @@ F: kernel/time/timer_list.c
>> F: kernel/time/timer_migration.*
>> F: tools/testing/selftests/timers/
>>
>> +DELAY AND SLEEP API [RUST]
>> +M: FUJITA Tomonori <fujita.tomonori@gmail.com>
>> +R: Boqun Feng <boqun.feng@gmail.com>
>> +R: Andreas Hindborg <a.hindborg@kernel.org>
>
> ... this "R:" entry would be "M:",
>
>> +R: Anna-Maria Behnsen <anna-maria@linutronix.de>
>> +R: Frederic Weisbecker <frederic@kernel.org>
>> +R: Thomas Gleixner <tglx@linutronix.de>
>> +L: rust-for-linux@vger.kernel.org
>> +L: linux-kernel@vger.kernel.org
>
> +T: git https://github.com/Rust-for-Linux/linux.git hrtimer-next
>
>> +S: Maintained
>
> I will let Andreas decide whether this is a "Supported" entry ;-)
>
>> +F: rust/kernel/time/delay.rs
>> +
>> HIGH-SPEED SCC DRIVER FOR AX.25
>> L: linux-hams@vger.kernel.org
>> S: Orphan
>> @@ -23944,6 +23956,17 @@ F: kernel/time/timekeeping*
>> F: kernel/time/time_test.c
>> F: tools/testing/selftests/timers/
>>
>> +TIMEKEEPING API [RUST]
>
> and similar things for this entry as well.
>
>> +M: FUJITA Tomonori <fujita.tomonori@gmail.com>
>> +R: Boqun Feng <boqun.feng@gmail.com>
>> +R: Andreas Hindborg <a.hindborg@kernel.org>
>> +R: John Stultz <jstultz@google.com>
>> +R: Thomas Gleixner <tglx@linutronix.de>
>
> +R: Stephen Boyd <sboyd@kernel.org>
>
> ?
>
>> +L: rust-for-linux@vger.kernel.org
>> +L: linux-kernel@vger.kernel.org
>> +S: Maintained
>> +F: rust/kernel/time.rs
>> +
>
> Tomo, let's wait for Andreas' rely and decide how to change these
> entries. Thanks!

My recommendation would be to take all of `rust/kernel/time` under one
entry for now. I suggest the following, folding in the hrtimer entry as
well:

DELAY, SLEEP, TIMEKEEPING, TIMERS [RUST]
M: Andreas Hindborg <a.hindborg@kernel.org>
R: Boqun Feng <boqun.feng@gmail.com>
R: FUJITA Tomonori <fujita.tomonori@gmail.com>
R: Lyude Paul <lyude@redhat.com>
R: Frederic Weisbecker <frederic@kernel.org>
R: Thomas Gleixner <tglx@linutronix.de>
R: Anna-Maria Behnsen <anna-maria@linutronix.de>
R: John Stultz <jstultz@google.com>
L: rust-for-linux@vger.kernel.org
S: Supported
W: https://rust-for-linux.com
B: https://github.com/Rust-for-Linux/linux/issues
T: git https://github.com/Rust-for-Linux/linux.git rust-timekeeping-next
F: rust/kernel/time.rs
F: rust/kernel/time/

If that is acceptable to everyone, it is very likely that I can pick 2-6
for v6.16.

I assume patch 1 will go through the sched/core tree, and then Miguel
can pick 7.

Best regards,
Andreas Hindborg