Re: [PATCH v11 7/8] rust: Add read_poll_timeout functions

FUJITA Tomonori
2025-08-14T05:53:28Z

On Mon, 11 Aug 2025 11:42:46 +0200
Andreas Hindborg <a.hindborg@kernel.org> wrote:

>>> Could you document the reason for the test. As an example, this code is
>>> not really usable. `#[test]` was staged for 6.15, so perhaps move this
>>> to a unit test instead?
>>>
>>> The test throws this BUG, which is what I think is also your intention:
>>
>> might_sleep() doesn't throw BUG(), just a warning. Can the test
>> infrastructure handle such?
>
> As I wrote, kunit does not handle this. But I am confused about the
> bug/warn comment. The trace I pasted clearly says "BUG"?

Yeah, might_sleep() says "BUG" like BUG() macros but they are
different. might_sleep() simply prints debug information.

> I think we should just remove this test for now.

I'll do in the next version.