From: Jarkko Sakkinen <jarkko@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] tpm: tpm_tis_spi: Mark ACPI and OF related data as maybe unused
Date: Sun, 12 Mar 2023 03:53:38 +0200 [thread overview]
Message-ID: <ZA0wor67TlOdBOs/@kernel.org> (raw)
In-Reply-To: <20230311173541.262949-2-krzysztof.kozlowski@linaro.org>
On Sat, Mar 11, 2023 at 06:35:41PM +0100, Krzysztof Kozlowski wrote:
> The driver can be compile tested with !CONFIG_OF or !CONFIG_ACPI making
> unused:
>
> drivers/char/tpm/tpm_tis_spi_main.c:234:34: error: ‘of_tis_spi_match’ defined but not used [-Werror=unused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> drivers/char/tpm/tpm_tis_spi_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm_tis_spi_main.c b/drivers/char/tpm/tpm_tis_spi_main.c
> index a0963a3e92bd..1f5207974a17 100644
> --- a/drivers/char/tpm/tpm_tis_spi_main.c
> +++ b/drivers/char/tpm/tpm_tis_spi_main.c
> @@ -231,7 +231,7 @@ static const struct spi_device_id tpm_tis_spi_id[] = {
> };
> MODULE_DEVICE_TABLE(spi, tpm_tis_spi_id);
>
> -static const struct of_device_id of_tis_spi_match[] = {
> +static const struct of_device_id of_tis_spi_match[] __maybe_unused = {
> { .compatible = "st,st33htpm-spi", .data = tpm_tis_spi_probe },
> { .compatible = "infineon,slb9670", .data = tpm_tis_spi_probe },
> { .compatible = "tcg,tpm_tis-spi", .data = tpm_tis_spi_probe },
> @@ -240,7 +240,7 @@ static const struct of_device_id of_tis_spi_match[] = {
> };
> MODULE_DEVICE_TABLE(of, of_tis_spi_match);
>
> -static const struct acpi_device_id acpi_tis_spi_match[] = {
> +static const struct acpi_device_id acpi_tis_spi_match[] __maybe_unused = {
> {"SMO0768", 0},
> {}
> };
> --
> 2.34.1
>
Ditto.
BR, Jarkko
next prev parent reply other threads:[~2023-03-12 1:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 17:35 [PATCH 1/2] tpm: st33zp24: Mark ACPI and OF related data as maybe unused Krzysztof Kozlowski
2023-03-11 17:35 ` [PATCH 2/2] tpm: tpm_tis_spi: " Krzysztof Kozlowski
2023-03-12 1:53 ` Jarkko Sakkinen [this message]
2023-03-12 10:06 ` Krzysztof Kozlowski
2023-03-12 1:53 ` [PATCH 1/2] tpm: st33zp24: " Jarkko Sakkinen
2023-03-12 10:06 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZA0wor67TlOdBOs/@kernel.org \
--to=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox