From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wolfram Sang <wsa@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Lee Jones <lee@kernel.org>,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] driver core: bus: Handle early calls to bus_to_subsys()
Date: Thu, 2 Mar 2023 11:20:37 +0100 [thread overview]
Message-ID: <ZAB4dVeQEZyxhx3Z@kroah.com> (raw)
In-Reply-To: <Y/3d/sfipoe130Hu@ninjato>
On Tue, Feb 28, 2023 at 11:57:02AM +0100, Wolfram Sang wrote:
> On Tue, Feb 21, 2023 at 01:53:51PM +0100, Geert Uytterhoeven wrote:
> > When calling soc_device_match() from early_initcall(), bus_kset is still
> > NULL, causing a crash:
> >
> > Unable to handle kernel NULL pointer dereference at virtual address 0000000000000028
> > ...
> > Call trace:
> > __lock_acquire+0x530/0x20f0
> > lock_acquire.part.0+0xc8/0x210
> > lock_acquire+0x64/0x80
> > _raw_spin_lock+0x4c/0x60
> > bus_to_subsys+0x24/0xac
> > bus_for_each_dev+0x30/0xcc
> > soc_device_match+0x4c/0xe0
> > r8a7795_sysc_init+0x18/0x60
> > rcar_sysc_pd_init+0xb0/0x33c
> > do_one_initcall+0x128/0x2bc
> >
> > Before, bus_for_each_dev() handled this gracefully by checking that
> > the back-pointer to the private structure was valid.
> >
> > Fix this by adding a NULL check for bus_kset to bus_to_subsys().
> >
> > Fixes: 83b9148df2c95e23 ("driver core: bus: bus iterator cleanups")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Current top-of-head doesn't boot my Salvator-XS board, this patch fixed
> it.
>
> Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
Great, now sent to Linus.
greg k-h
prev parent reply other threads:[~2023-03-02 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 12:53 [PATCH] driver core: bus: Handle early calls to bus_to_subsys() Geert Uytterhoeven
2023-02-21 13:47 ` Greg Kroah-Hartman
2023-02-28 10:57 ` Wolfram Sang
2023-03-02 10:20 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAB4dVeQEZyxhx3Z@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=geert+renesas@glider.be \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox