Re: [PATCH v5 03/12] dt-bindings: net: snps,dwmac: Add an optional resets single 'ahb'

Rob Herring
2023-03-08T21:57:23Z

On Fri, Mar 03, 2023 at 04:59:19PM +0800, Samin Guo wrote:
> According to:
> stmmac_platform.c: stmmac_probe_config_dt
> stmmac_main.c: stmmac_dvr_probe

That's not really a reason on its own. Maybe the driver is wrong. Do we
know what hardware needs this?

> dwmac controller may require one (stmmaceth) or two (stmmaceth+ahb)
> reset signals, and the maxItems of resets/reset-names is going to be 2.
>
> Signed-off-by: Samin Guo <samin.guo@starfivetech.com>
> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 14 ++++++++++----
> 1 file changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index b4135d5297b4..89099a888f0b 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -133,12 +133,18 @@ properties:
> - ptp_ref
>
> resets:
> - maxItems: 1
> - description:
> - MAC Reset signal.
> + minItems: 1
> + items:
> + - description: GMAC stmmaceth reset
> + - description: AHB reset
>
> reset-names:
> - const: stmmaceth
> + minItems: 1
> + maxItems: 2
> + contains:

This means 'reset-names = "foo", "ahb";' is valid. You want 'items'
instead. However, that still allows the below string in any order. Do we
really need that? If not, then you want:

items:
- const: stmmaceth
- const: ahb

> + enum:
> + - stmmaceth
> + - ahb
>
> power-domains:
> maxItems: 1
> --
> 2.17.1
>