From: "Theodore Ts'o" <tytso@mit.edu>
To: Nick Terrell <terrelln@meta.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Nick Terrell <nickrterrell@gmail.com>
Subject: Re: [GIT PULL] zstd changes for v6.3-rc1
Date: Fri, 3 Mar 2023 13:48:44 -0500 [thread overview]
Message-ID: <ZAJBDEQv+L6e0Ig4@mit.edu> (raw)
In-Reply-To: <2B90FACE-74EB-47C8-91FD-62E3F77B95EC@meta.com>
On Fri, Mar 03, 2023 at 06:03:50PM +0000, Nick Terrell wrote:
>
> What do you prefer I do with my current tree? I guess I can either:
> - Leave the merges in and keep a stable tree
> - Fix up my tree and clean up the merges, but break the stable tree
Do you have any downstream trees that depend on your tree? If you
don't anyone who might be using your tree as a base for forther work
(linux-next doesn't count, since it rewinds every working day).
In general, for most "leaf" trees, rewinding your branches is not a
big deal. There are some people who worship at the altar of "stable
git branches which never be rewound, forever and ever, Amen". But
that is really a religious belief, and it's one that I don't subscribe
to.
Sure, if someone is depending on your git tree then rewinding the
branch can cause them problems. But not all subsystem trees are used
by others as a basis for further work! There are benefits to
rewinding / rebasing patches; sometimes I'll do rewind the ext4 dev
branch to add a "Tested-By", or to drop a patch which I had merged,
but then later on I discovered that it causes regressions. In that
case, I'll drop the patch using git rebase -i since it can make life
easier who are doing git bisects.
Cheers,
- Ted
next prev parent reply other threads:[~2023-03-03 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 6:23 [GIT PULL] zstd changes for v6.3-rc1 Nick Terrell
2023-03-03 17:28 ` Linus Torvalds
2023-03-03 17:54 ` Nick Terrell
2023-03-03 17:59 ` Linus Torvalds
2023-03-03 18:03 ` Nick Terrell
2023-03-03 18:16 ` Linus Torvalds
2023-03-03 18:26 ` Nick Terrell
2023-03-03 18:48 ` Theodore Ts'o [this message]
2023-03-03 18:05 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAJBDEQv+L6e0Ig4@mit.edu \
--to=tytso@mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=nickrterrell@gmail.com \
--cc=terrelln@meta.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox