Re: [PATCH v7 5/5] arm64: dts: qcom: Add msm8939 Sony Xperia M4 Aqua

Bryan O'Donoghue
2023-03-06T22:56:34Z

On 06/03/2023 16:14, Stephan Gerhold wrote:
> There are*a lot* of unused pinctrl entries here. If you don't reference
> them anywhere (by referencing them via label) they just waste space in
> the device tree. The GPIOs will still remain unconfigured.
>
> Please save them locally for later usage and only keep the used entries.
> This will ease review of upcoming patches since these are better
> understandable together with the actual device node making use of them.

TBH, I really would have rather received this comment @ version 1,
before doing all the work to sanitise the incoming downstream DTS.

But sure, no problem, I'll drop.

---
bod