From: Nicolas Schier <nicolas@fjasle.eu>
To: Bastian Germann <bage@linutronix.de>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] kbuild: deb-pkg: default dpkg-buildpackage --build
Date: Mon, 6 Mar 2023 18:04:31 +0100 [thread overview]
Message-ID: <ZAYdH6huDB9QtNdR@fjasle.eu> (raw)
In-Reply-To: <20230305232536.19528-2-bage@linutronix.de>
[-- Attachment #1: Type: text/plain, Size: 1304 bytes --]
On Mon, Mar 06, 2023 at 12:25:35AM +0100 Bastian Germann wrote:
> deb-pkg's dpkg-buildpackage invocation was added --build=source,binary
> recently. Before, it relied on the default, which is
> --build=source,binary,all and makes no difference for the built packages
> as there is no "Arch: all" package.
>
> However, the explicit --build eliminates overriding it via DPKG_FLAGS,
> which used to fill the gap of generating only a source package without
> building it.
>
> Recover the old, default behavior.
>
> Fixes: 7bf4582d7aad ("kbuild: deb-pkg: create source package without cleaning")
> Signed-off-by: Bastian Germann <bage@linutronix.de>
> ---
> scripts/Makefile.package | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> index b941e6341b36..fe1721915a59 100644
> --- a/scripts/Makefile.package
> +++ b/scripts/Makefile.package
> @@ -120,7 +120,7 @@ debian-orig: linux.tar.gz debian
> PHONY += deb-pkg
> deb-pkg: debian-orig
> +dpkg-buildpackage -r$(KBUILD_PKG_ROOTCMD) -a$$(cat debian/arch) $(DPKG_FLAGS) \
> - --build=source,binary -nc -us -uc
> + -nc -us -uc
>
> PHONY += bindeb-pkg
> bindeb-pkg: debian
> --
> 2.39.2
Reviewed-by: Nicolas Schier <nicolas@fjasle.eu>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-03-06 17:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-05 23:25 [PATCH 0/1] kbuild: deb-pkg: default dpkg-buildpackage --build Bastian Germann
2023-03-05 23:25 ` [PATCH 1/1] " Bastian Germann
2023-03-06 17:04 ` Nicolas Schier [this message]
2023-03-07 3:21 ` Masahiro Yamada
2023-03-07 8:44 ` Bastian Germann
2023-03-07 11:12 ` Masahiro Yamada
2023-03-07 11:20 ` [PATCH v2 0/1] " Bastian Germann
2023-03-07 11:20 ` [PATCH v2 1/1] " Bastian Germann
2023-03-10 14:37 ` Masahiro Yamada
2023-03-10 14:49 ` Bastian Germann
2023-03-10 15:25 ` Bastian Germann
2023-03-06 14:30 ` [PATCH 0/1] " Nicolas Schier
2023-03-06 14:36 ` Bastian Germann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAYdH6huDB9QtNdR@fjasle.eu \
--to=nicolas@fjasle.eu \
--cc=bage@linutronix.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox