public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Khadija <kamrankhadijadj@gmail.com>
Cc: Dan Carpenter <error27@gmail.com>,
	outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: alignment should match opening parenthesis in axis-fifo.c
Date: Tue, 7 Mar 2023 09:18:36 +0100	[thread overview]
Message-ID: <ZAbzXA5+tMaagtFj@kroah.com> (raw)
In-Reply-To: <CACcTnM5kVTG3JaLK9mjaOO7qcXoTrb4xsg2af5Ac1ScqFfbjTg@mail.gmail.com>

On Tue, Mar 07, 2023 at 01:10:17PM +0500, Khadija wrote:
> Hey Dan! Thank you for your feedback.
> Yes, the code currently looks unreadable. I am making changes and resending
> the patch.
> Also, on running checkpatch.pl on my patch file I get a warning about 75
> chars per line. Is there a way of fixing it automatically using script?

Hi,

Minor housekeeping notes.  Your email client is sending out html email,
which is rejected by the public mailing lists.  Please reconfigure it to
not do that.

Also, try not to ever top-post like this, it breaks the review process
and makes it impossible at times to determine what you are actually
responding back to.  Read some of the mailing list archives at
lore.kernel.org for examples of the proper way to respond to messages
inline.

thanks,

greg k-h

      parent reply	other threads:[~2023-03-07  8:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-06 20:52 [PATCH] staging: axis-fifo: alignment should match opening parenthesis in axis-fifo.c Khadija Kamran
2023-03-06 21:08 ` Julia Lawall
     [not found]   ` <CACcTnM5GR0ZM5WBaL+BDEK_0QJGr6h2t4tnsnjerHta_nq6Tmg@mail.gmail.com>
2023-03-07  7:49     ` Julia Lawall
2023-03-07  8:02       ` Dan Carpenter
2023-03-07  8:07         ` Julia Lawall
2023-03-07  8:14           ` Dan Carpenter
     [not found]       ` <CACcTnM4OHFiGrEez6dMzd4jO4YuQZzqpUK86UBMzhd+nFDWezA@mail.gmail.com>
2023-03-07  8:13         ` Julia Lawall
2023-03-10 16:01           ` Khadija Kamran
2023-03-11  8:56             ` Julia Lawall
2023-03-11  9:21               ` Khadija Kamran
2023-03-07  7:13 ` Dan Carpenter
     [not found]   ` <CACcTnM5kVTG3JaLK9mjaOO7qcXoTrb4xsg2af5Ac1ScqFfbjTg@mail.gmail.com>
2023-03-07  8:18     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAbzXA5+tMaagtFj@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=error27@gmail.com \
    --cc=kamrankhadijadj@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox