From: Andy Shevchenko <andy@kernel.org>
To: Andrew Davis <afd@ti.com>
Cc: Peter Tyser <ptyser@xes-inc.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path
Date: Tue, 7 Mar 2023 19:44:04 +0200 [thread overview]
Message-ID: <ZAd35D4C96MP5Qrm@smile.fi.intel.com> (raw)
In-Reply-To: <20230307165432.25484-4-afd@ti.com>
On Tue, Mar 07, 2023 at 10:54:30AM -0600, Andrew Davis wrote:
> Use devm version of gpiochip add function to handle removal for us.
>
> While here update copyright and module author.
...
> - mutex_destroy(&gpio->lock);
You need to wrap this into devm.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-07 17:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 16:54 [PATCH 1/6] gpio: ich: Use devm_gpiochip_add_data() to simplify remove path Andrew Davis
2023-03-07 16:54 ` [PATCH 2/6] gpio: twl4030: " Andrew Davis
2023-03-07 17:45 ` Andy Shevchenko
2023-03-07 17:51 ` Andrew Davis
2023-03-07 16:54 ` [PATCH 3/6] gpio: sch311x: " Andrew Davis
2023-03-08 10:24 ` Bartosz Golaszewski
2023-03-08 10:32 ` Bartosz Golaszewski
2023-03-08 15:50 ` Andrew Davis
2023-03-08 15:53 ` Andy Shevchenko
2023-03-08 16:20 ` Andrew Davis
2023-03-08 16:32 ` Andy Shevchenko
2023-03-07 16:54 ` [PATCH 4/6] gpio: pisosr: " Andrew Davis
2023-03-07 17:44 ` Andy Shevchenko [this message]
2023-03-07 17:55 ` Andrew Davis
2023-03-07 18:05 ` Andy Shevchenko
2023-03-08 10:27 ` Bartosz Golaszewski
2023-03-07 16:54 ` [PATCH 5/6] gpio: tpic2810: " Andrew Davis
2023-03-08 10:28 ` Bartosz Golaszewski
2023-03-08 10:33 ` Bartosz Golaszewski
2023-03-07 16:54 ` [PATCH 6/6] gpio: tps65086: " Andrew Davis
2023-03-08 10:29 ` Bartosz Golaszewski
2023-03-07 17:41 ` [PATCH 1/6] gpio: ich: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAd35D4C96MP5Qrm@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=afd@ti.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox