From: Simon Horman <horms@kernel.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Eric Biederman <ebiederm@xmission.com>,
Dave Hansen <dave.hansen@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>, Baoquan He <bhe@redhat.com>,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH v2 1/2] x86/kexec: Remove unnecessary arch_kexec_kernel_image_load()
Date: Wed, 8 Mar 2023 11:44:57 +0100 [thread overview]
Message-ID: <ZAhnKdXbf2fa9Ql8@kernel.org> (raw)
In-Reply-To: <20230307224416.907040-2-helgaas@kernel.org>
On Tue, Mar 07, 2023 at 04:44:15PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The x86 implementation of arch_kexec_kernel_image_load() is functionally
> identical to the generic arch_kexec_kernel_image_load():
>
> arch_kexec_kernel_image_load # x86
> if (!image->fops || !image->fops->load)
> return ERR_PTR(-ENOEXEC);
> return image->fops->load(image, image->kernel_buf, ...)
>
> arch_kexec_kernel_image_load # generic
> kexec_image_load_default
> if (!image->fops || !image->fops->load)
> return ERR_PTR(-ENOEXEC);
> return image->fops->load(image, image->kernel_buf, ...)
>
> Remove the x86-specific version and use the generic
> arch_kexec_kernel_image_load(). No functional change intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-03-08 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 22:44 [PATCH v2 0/2] kexec: Remove unnecessary arch hook Bjorn Helgaas
2023-03-07 22:44 ` [PATCH v2 1/2] x86/kexec: Remove unnecessary arch_kexec_kernel_image_load() Bjorn Helgaas
2023-03-08 10:44 ` Simon Horman [this message]
2023-03-07 22:44 ` [PATCH v2 2/2] kexec: " Bjorn Helgaas
2023-03-08 10:45 ` Simon Horman
2023-03-08 0:37 ` [PATCH v2 0/2] kexec: Remove unnecessary arch hook Baoquan He
2023-03-23 7:49 ` Baoquan He
2023-03-23 22:07 ` Andrew Morton
2023-03-24 1:43 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAhnKdXbf2fa9Ql8@kernel.org \
--to=horms@kernel.org \
--cc=bhe@redhat.com \
--cc=bhelgaas@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=ebiederm@xmission.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox