From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Andrew Davis <afd@ti.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Peter Tyser <ptyser@xes-inc.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] gpio: sch311x: Use devm_gpiochip_add_data() to simplify remove path
Date: Wed, 8 Mar 2023 18:32:56 +0200 [thread overview]
Message-ID: <ZAi4uJdqlNfq0q2/@smile.fi.intel.com> (raw)
In-Reply-To: <f7561edb-be14-d78e-0f97-54ef6bd4eaea@ti.com>
On Wed, Mar 08, 2023 at 10:20:13AM -0600, Andrew Davis wrote:
> On 3/8/23 9:53 AM, Andy Shevchenko wrote:
> > On Wed, Mar 8, 2023 at 5:50 PM Andrew Davis <afd@ti.com> wrote:
> > > On 3/8/23 4:32 AM, Bartosz Golaszewski wrote:
> > > > On Wed, Mar 8, 2023 at 11:24 AM Bartosz Golaszewski <brgl@bgdev.pl> wrote:
...
> > > > I see there's v2 out, backing it out then.
> > >
> > > Looks like I missed something that kernel test robot found, so there
> > > will be a v3.
> >
> > Just split your series on a per driver basis. This will help with
> > understanding what's going on. Also use a cover letter to explain what
> > your series is for.
>
> There is one patch per driver, not sure what you mean by split per driver?
In the future for similar cases it's better to split the series on the driver
basis, so each patch is sent separately and handled individually. That way
you won't need to resend the whole bunch over and over because of some subtle
mistake made in the middle.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-08 16:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 16:54 [PATCH 1/6] gpio: ich: Use devm_gpiochip_add_data() to simplify remove path Andrew Davis
2023-03-07 16:54 ` [PATCH 2/6] gpio: twl4030: " Andrew Davis
2023-03-07 17:45 ` Andy Shevchenko
2023-03-07 17:51 ` Andrew Davis
2023-03-07 16:54 ` [PATCH 3/6] gpio: sch311x: " Andrew Davis
2023-03-08 10:24 ` Bartosz Golaszewski
2023-03-08 10:32 ` Bartosz Golaszewski
2023-03-08 15:50 ` Andrew Davis
2023-03-08 15:53 ` Andy Shevchenko
2023-03-08 16:20 ` Andrew Davis
2023-03-08 16:32 ` Andy Shevchenko [this message]
2023-03-07 16:54 ` [PATCH 4/6] gpio: pisosr: " Andrew Davis
2023-03-07 17:44 ` Andy Shevchenko
2023-03-07 17:55 ` Andrew Davis
2023-03-07 18:05 ` Andy Shevchenko
2023-03-08 10:27 ` Bartosz Golaszewski
2023-03-07 16:54 ` [PATCH 5/6] gpio: tpic2810: " Andrew Davis
2023-03-08 10:28 ` Bartosz Golaszewski
2023-03-08 10:33 ` Bartosz Golaszewski
2023-03-07 16:54 ` [PATCH 6/6] gpio: tps65086: " Andrew Davis
2023-03-08 10:29 ` Bartosz Golaszewski
2023-03-07 17:41 ` [PATCH 1/6] gpio: ich: " Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAi4uJdqlNfq0q2/@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=afd@ti.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ptyser@xes-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox