From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Arnd Bergmann <arnd@arndb.de>,
Naresh Kamboju <naresh.kamboju@linaro.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mips: ar71: include linux/gpio/driver.h
Date: Wed, 8 Mar 2023 17:37:53 +0200 [thread overview]
Message-ID: <ZAir0b1aPYQdyNRm@smile.fi.intel.com> (raw)
In-Reply-To: <20230308145303.826942-1-arnd@kernel.org>
On Wed, Mar 08, 2023 at 03:52:53PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The change to remove the implicit gpio/driver.h include was done
> after fixing all the other users, but the ar7 file still needs
> the same change.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Thank you!
P.S. Bart, I believe the best strategy here is to you directly apply this to
GPIO tree. If anyone needs this, you can make an immutable tag or branch with
it being included.
Alternatively I can take it and issue a new immutable tag.
Tell me which way suits you better.
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
> Fixes: 21d9526d13b5 ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> arch/mips/ar7/gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/ar7/gpio.c b/arch/mips/ar7/gpio.c
> index ae0e01b9438f..4ed833b9cc2f 100644
> --- a/arch/mips/ar7/gpio.c
> +++ b/arch/mips/ar7/gpio.c
> @@ -7,7 +7,7 @@
>
> #include <linux/init.h>
> #include <linux/export.h>
> -#include <linux/gpio.h>
> +#include <linux/gpio/driver.h>
>
> #include <asm/mach-ar7/ar7.h>
>
> --
> 2.39.2
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-08 15:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 14:52 [PATCH] mips: ar71: include linux/gpio/driver.h Arnd Bergmann
2023-03-08 15:37 ` Andy Shevchenko [this message]
2023-03-08 21:56 ` Linus Walleij
2023-03-09 14:05 ` Andy Shevchenko
2023-03-09 14:21 ` Linus Walleij
2023-03-09 14:57 ` Philippe Mathieu-Daudé
2023-03-09 22:04 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAir0b1aPYQdyNRm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox