Re: [RFC PATCH v2 4/7] soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver

Eric Biggers
2023-03-08T20:01:56Z

On Wed, Mar 08, 2023 at 05:58:35PM +0200, Abel Vesa wrote:
> * Switched QCOM_INLINE_CRYPTO_ENGINE to tristate and made it built-in
> if any of the UFS or the SDHC drivers are built-in. This is to allow
> the API to be available even if the built-in driver doesn't have
> crypto enabled.
[...]
> diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
> index a8f283086a21..c584369e9810 100644
> --- a/drivers/soc/qcom/Kconfig
> +++ b/drivers/soc/qcom/Kconfig
> @@ -275,4 +275,10 @@ config QCOM_ICC_BWMON
> the fixed bandwidth votes from cpufreq (CPU nodes) thus achieve high
> memory throughput even with lower CPU frequencies.
>
> +config QCOM_INLINE_CRYPTO_ENGINE
> + tristate
> + depends on SCSI_UFS_CRYPTO || MMC_CRYPTO
> + default y if SCSI_UFS_QCOM=y || MMC_SDHCI_MSM=y
> + select QCOM_SCM

What are the "depends on" and "default y" lines above for?

You're already selecting this from SCSI_UFS_QCOM and MSM_SDHCI_MSM, as I had
suggested. Isn't that enough?

- Eric