From: Chen Yu <yu.c.chen@intel.com>
To: kernel test robot <yujie.liu@intel.com>
Cc: Zhang Qiao <zhangqiao22@huawei.com>, <oe-lkp@lists.linux.dev>,
<lkp@intel.com>, <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Roman Kagan <rkagan@amazon.de>, <ying.huang@intel.com>,
<feng.tang@intel.com>, <zhengjun.xing@linux.intel.com>,
<fengwei.yin@intel.com>,
Vincent Guittot <vincent.guittot@linaro.org>
Subject: Re: [linus:master] [sched/fair] 829c1651e9: hackbench.throughput -7.9% regression
Date: Thu, 9 Mar 2023 16:21:11 +0800 [thread overview]
Message-ID: <ZAmW99UdQQEncV2l@chenyu5-mobl1> (raw)
In-Reply-To: <202303091155.672f546a-yujie.liu@intel.com>
On 2023-03-09 at 11:46:50 +0800, kernel test robot wrote:
> Greeting,
>
> FYI, we noticed a -7.9% regression of hackbench.throughput due to commit:
>
> commit: 829c1651e9c4a6f78398d3e67651cef9bb6b42cc ("sched/fair: sanitize vruntime of entity being placed")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> in testcase: hackbench
> on test machine: 104 threads 2 sockets (Skylake) with 192G memory
> with following parameters:
>
> nr_threads: 100%
> iterations: 4
> mode: process
> ipc: socket
> cpufreq_governor: performance
>
In theory the patch deals with a corner case that the task sleeps for more than 1 minute,
but this is not the case for hackbench, and it did increase the preemption:
1.08e+08 ± 2% +648.7% 8.084e+08 ± 5% hackbench.time.involuntary_context_switches
It might be an issue described and fixed here:
https://lore.kernel.org/lkml/20230306132418.50389-1-zhangqiao22@huawei.com/
https://lore.kernel.org/lkml/ZAiFxWLSb9HDazSI@vingu-book/
I'll check if above patch helps.
thanks,
Chenyu
prev parent reply other threads:[~2023-03-09 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 3:46 [linus:master] [sched/fair] 829c1651e9: hackbench.throughput -7.9% regression kernel test robot
2023-03-09 8:21 ` Chen Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAmW99UdQQEncV2l@chenyu5-mobl1 \
--to=yu.c.chen@intel.com \
--cc=feng.tang@intel.com \
--cc=fengwei.yin@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-lkp@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rkagan@amazon.de \
--cc=vincent.guittot@linaro.org \
--cc=ying.huang@intel.com \
--cc=yujie.liu@intel.com \
--cc=zhangqiao22@huawei.com \
--cc=zhengjun.xing@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox