Re: [PATCH v4 1/5] mfd: Add support for Intel LJCA device

Arnd Bergmann
2023-03-09T11:31:14Z

On Thu, Mar 9, 2023, at 12:03, Mark Brown wrote:
> On Thu, Mar 09, 2023 at 08:56:05AM +0100, Arnd Bergmann wrote:
>> On Thu, Mar 9, 2023, at 08:10, Ye Xiang wrote:
>
>> > drivers/usb/misc/Kconfig | 13 +
>> > drivers/usb/misc/Makefile | 1 +
>> > drivers/usb/misc/ljca.c | 969 ++++++++++++++++++++++++++++++++++++++
>> > include/linux/mfd/ljca.h | 95 ++++
>
>> Why is this in driver/usb/misc? It looks like a normal
>> mfd driver to me, and it evenhas the header in include/linux/mfd/
>
> It was a MFD in the original version, Lee asked for it to be moved to
> USB: https://lore.kernel.org/r/20230305103456.GF2574592@google.com

Ok, I see. That should probably be mentioned in the patch
description then. I'm still not sure I follow the reasoning
for the split between "usb functionality" and and mfd part:
This is just a usb driver as it is attached to a usb bus, and
drivers usually get put into a directory based on what they
provide, not how they are attached to a parent bus.

Arnd