From: Simon Horman <simon.horman@corigine.com>
To: "Radu Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH net] net: phy: nxp-c45-tja11xx: fix MII_BASIC_CONFIG_REV bit
Date: Thu, 9 Mar 2023 16:47:25 +0100 [thread overview]
Message-ID: <ZAn/jWfoR5jmiQnY@corigine.com> (raw)
In-Reply-To: <20230309100111.1246214-1-radu-nicolae.pirea@oss.nxp.com>
On Thu, Mar 09, 2023 at 12:01:11PM +0200, Radu Pirea (OSS) wrote:
> According to the TJA1103 user manual, the bit for the reversed role in MII
> or RMII modes is bit 4.
>
> Cc: <stable@vger.kernel.org> # 5.15+
I think this should include:
Fixes: b050f2f15e04 ("phy: nxp-c45: add driver for tja1103")
> Signed-off-by: Radu Pirea (OSS) <radu-nicolae.pirea@oss.nxp.com>
> ---
> drivers/net/phy/nxp-c45-tja11xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/nxp-c45-tja11xx.c b/drivers/net/phy/nxp-c45-tja11xx.c
> index 047c581457e3..5813b07242ce 100644
> --- a/drivers/net/phy/nxp-c45-tja11xx.c
> +++ b/drivers/net/phy/nxp-c45-tja11xx.c
> @@ -79,7 +79,7 @@
> #define SGMII_ABILITY BIT(0)
>
> #define VEND1_MII_BASIC_CONFIG 0xAFC6
> -#define MII_BASIC_CONFIG_REV BIT(8)
> +#define MII_BASIC_CONFIG_REV BIT(4)
> #define MII_BASIC_CONFIG_SGMII 0x9
> #define MII_BASIC_CONFIG_RGMII 0x7
> #define MII_BASIC_CONFIG_RMII 0x5
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-03-09 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 10:01 [PATCH net] net: phy: nxp-c45-tja11xx: fix MII_BASIC_CONFIG_REV bit Radu Pirea (OSS)
2023-03-09 15:47 ` Simon Horman [this message]
2023-03-11 5:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAn/jWfoR5jmiQnY@corigine.com \
--to=simon.horman@corigine.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radu-nicolae.pirea@oss.nxp.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox