The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Arnd Bergmann <arnd@arndb.de>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
	linux-gpio@vger.kernel.org, linux-sh@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Linux Kernel Functional Testing <lkft@linaro.org>
Subject: Re: [PATCH] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h>
Date: Thu, 9 Mar 2023 16:36:08 +0200	[thread overview]
Message-ID: <ZAnu2LwZWm3wi2l5@smile.fi.intel.com> (raw)
In-Reply-To: <CACRpkdant3mQJX0FM3q65mBaS0fXJ=7tag5dx-1Jp5xpc3EQJg@mail.gmail.com>

On Thu, Mar 09, 2023 at 03:08:47PM +0100, Linus Walleij wrote:
> On Thu, Mar 9, 2023 at 2:52 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> 
> > shx3_defconfig:
> >
> >     arch/sh/boards/mach-x3proto/setup.c: In function ‘x3proto_devices_setup’:
> >     arch/sh/boards/mach-x3proto/setup.c:246:62: error: invalid use of undefined type ‘struct gpio_chip’
> >       246 |                 baseboard_buttons[i].gpio = x3proto_gpio_chip.base + i;
> >           |                                                              ^
> >
> > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> > Link: https://lore.kernel.org/r/CA+G9fYs7suzGsEDK40G0pzxXyR1o2V4Pn-oy1owTsTWRVEVHog@mail.gmail.com
> > Fixes: 21d9526d13b5467b ("gpiolib: Make the legacy <linux/gpio.h> consumer-only")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> This is fallout from cleanups in Bartosz GPIO tree, so it will be applied there.
> Make sure Bartosz gets the patch (now on To:)
> 
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks, as for previous patch on the same topic, I am collecting this one.

I will sent a new PR to Bart including all fixes, but I would wait one or a
couple of weeks before doing that. Meanwhile these will be in Linux Next.

-- 
With Best Regards,
Andy Shevchenko



      reply	other threads:[~2023-03-09 15:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-09 13:52 [PATCH] sh: mach-x3proto: Add missing #include <linux/gpio/driver.h> Geert Uytterhoeven
2023-03-09 13:54 ` John Paul Adrian Glaubitz
2023-03-09 13:56   ` Geert Uytterhoeven
2023-03-09 13:58     ` John Paul Adrian Glaubitz
2023-03-09 14:04 ` Andy Shevchenko
2023-03-09 14:35   ` Geert Uytterhoeven
2023-03-09 14:08 ` Linus Walleij
2023-03-09 14:36   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAnu2LwZWm3wi2l5@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=brgl@bgdev.pl \
    --cc=dalias@libc.org \
    --cc=geert+renesas@glider.be \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=lkft@linaro.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox