* [PATCH] staging: android: ashmem.c: Declared file operation with const keyword
@ 2023-03-05 19:00 Santosh Mahto
2023-03-09 14:41 ` Greg Kroah-Hartman
0 siblings, 1 reply; 2+ messages in thread
From: Santosh Mahto @ 2023-03-05 19:00 UTC (permalink / raw)
Cc: eisantosh95, Greg Kroah-Hartman, Arve Hjønnevåg,
Todd Kjos, Martijn Coenen, Joel Fernandes, Christian Brauner,
devel, linux-kernel
Warning found by checkpatch.pl script.
Signed-off-by: Santosh Mahto <eisantosh95@gmail.com>
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index c05a214191da..f9cfa15b785f 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -367,7 +367,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
static int ashmem_mmap(struct file *file, struct vm_area_struct *vma)
{
- static struct file_operations vmfile_fops;
+ static const struct file_operations vmfile_fops;
struct ashmem_area *asma = file->private_data;
int ret = 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: android: ashmem.c: Declared file operation with const keyword
2023-03-05 19:00 [PATCH] staging: android: ashmem.c: Declared file operation with const keyword Santosh Mahto
@ 2023-03-09 14:41 ` Greg Kroah-Hartman
0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2023-03-09 14:41 UTC (permalink / raw)
To: Santosh Mahto
Cc: devel, Todd Kjos, linux-kernel, Arve Hjønnevåg,
Christian Brauner, Joel Fernandes, Martijn Coenen
On Mon, Mar 06, 2023 at 12:30:57AM +0530, Santosh Mahto wrote:
> Warning found by checkpatch.pl script.
>
> Signed-off-by: Santosh Mahto <eisantosh95@gmail.com>
> ---
> drivers/staging/android/ashmem.c | 2 +-
What kernel did you make this against? This is not in my tree anymore.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-09 14:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-05 19:00 [PATCH] staging: android: ashmem.c: Declared file operation with const keyword Santosh Mahto
2023-03-09 14:41 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox