From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD4FC6FD19 for ; Fri, 10 Mar 2023 09:43:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230427AbjCJJne (ORCPT ); Fri, 10 Mar 2023 04:43:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230110AbjCJJmu (ORCPT ); Fri, 10 Mar 2023 04:42:50 -0500 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2365C212A2 for ; Fri, 10 Mar 2023 01:42:19 -0800 (PST) Received: by mail-wr1-x432.google.com with SMTP id l1so4424847wry.12 for ; Fri, 10 Mar 2023 01:42:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1678441337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LPInLZOYzoIRoYx9Oo6+KDA8Q8BwRlCDWnK6VRoNQtY=; b=VksT2yUtiBhAGeXiIMD5vubmOwq8Z+1ZDssMnKiobsfS7Pa4KkKezwLm1LP53Qsbpx bqhSoOGTWnasgW5MYrdFS0LiG9+8F1RXqkc8bCBg9+rVlq3Wnq0lXTA/ZeKwKcCPHaJS 7OmpFCM3pigjrmMrKTNpXw+5mO6xr82fTzpAVnIAtx/cUTHESxBK77usRf9RD+b1HoyE Q+/JnQ+iCNdAY4Vyx9X9Q/uRIQ9pmuwjzXXF/G7Ceh375fO3BxUEjqR6GNQwpyoLA6x1 noS1yhDL3BTa9W+wwwyUS+g31jas1IFYIJtkIaLzttgWOSuI4gE4ZHeMSepncJfLezsh hV5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678441337; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LPInLZOYzoIRoYx9Oo6+KDA8Q8BwRlCDWnK6VRoNQtY=; b=py0ax3Agyc+4GIziF6ie/ftbo07KcQiGYySI2fvGxl9RXLip8R0QFY3RYYUtlYHZ5y vKBbQTSRydjNrAtwbgfjiIsp7Amj+EidCB9uFulV3+ngxgjFD151mmFPBEsYgamaIohf OLrCUjgHpW75T2FGaVGWdLDE4rsS9oxWu1EA4BlJ0QL9fWnfD0AO9cd1afiKtHhOI5/i nshhDlGVCb7XS+i2suX72wV3oCVO2omZbITugoK9NGpVaM4ncfEYLFiDQBGXRs6aIkcu /ZrQMljsIm3ZxFXV6aqwptbtTkx3XXS1kBLjNuJ0xPLVD4VhQXRaCojChVDNynmmlSfZ DUOQ== X-Gm-Message-State: AO0yUKXR90p85dKUh+65RQ1NkCl9D/ogMAAhvvhJQSKX6gasn+D6QGvG yVRRozkOtmCy82OKa4IxK+TRfJbkXrQudq/FRKQ= X-Google-Smtp-Source: AK7set9RTGOc68ELXC0tenT4FKlqCU3FXruN/fg2t3uOkYxqzGZ8byBrnmngtpQdc6EUT36OJxzkRA== X-Received: by 2002:a5d:5386:0:b0:2c3:e20b:82aa with SMTP id d6-20020a5d5386000000b002c3e20b82aamr16264290wrv.22.1678441336747; Fri, 10 Mar 2023 01:42:16 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id t15-20020adfe10f000000b002c5526234d2sm1671789wrz.8.2023.03.10.01.42.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 01:42:14 -0800 (PST) Date: Fri, 10 Mar 2023 11:42:12 +0200 From: Abel Vesa To: Krzysztof Kozlowski Cc: Eric Biggers , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , Adrian Hunter , "James E . J . Bottomley" , "Martin K . Petersen" , linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [RFC PATCH v2 7/7] arm64: dts: qcom: Add the Inline Crypto Engine nodes Message-ID: References: <20230308155838.1094920-1-abel.vesa@linaro.org> <20230308155838.1094920-8-abel.vesa@linaro.org> <4eab53fc-2d26-dc93-3ae6-c0b2546ad3e0@linaro.org> <4ea944dd-8a42-e83f-607c-1a36124d19bb@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-03-10 10:37:42, Krzysztof Kozlowski wrote: > On 10/03/2023 10:34, Abel Vesa wrote: > >>> I assume you mean it breaks if someone is using old approach DTS with a > >>> kernel that would have ICE driver merged. Yes, that it does. And for > >>> that, in the v3, I'll make of_qcom_ice_get check if there is a reg entry > >>> with name "ice" and create an ICE instance but for the same dev as the > >>> consumer driver. OTOH, if there is no reg entry called "ice", it will > >>> look up a device based on phande of qcom,ice property. This will allow > >>> legacy style DTS to work fine, while using the unified driver as a > >>> library, in that case. For newer platforms, the recommended approach > >>> will be to add a new ICE node and use qcom,ice property. > >> > >> For the driver this sounds good. I still think that existing (older) DTS > >> should not have regs removed, because this affects other users of kernel > >> DTS. > > > > Yes, that's what I meant, the already supported platforms will remain > > with ice reg in the consumer node. > > ... unless you plan to add to them UFS ICE, which would be nice feature > thus justifying DTS re-shuffle :) By supported I meant the ones that have ICE support already :) > > Best regards, > Krzysztof >