From: Khadija Kamran <kamrankhadijadj@gmail.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: alignment should match opening parenthesis in axis-fifo.c
Date: Sat, 11 Mar 2023 14:21:18 +0500 [thread overview]
Message-ID: <ZAxIDlfL/+n4Pkyo@khadija-virtual-machine> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2303110954590.2802@hadrien>
On Sat, Mar 11, 2023 at 09:56:06AM +0100, Julia Lawall wrote:
>
>
> On Fri, 10 Mar 2023, Khadija Kamran wrote:
>
> > On Tue, Mar 07, 2023 at 09:13:49AM +0100, Julia Lawall wrote:
> > > There are actually two similar issues in axis-fifo.c. You could fix them
> > > both at once.
> >
> > Hey Julia!
> > I have a question. Should I send the two fixes as a patchset of two
> > patches, and should I send it as [PATCH v2]?
> > Thank you.
>
> The two issues in axis-fifo.c are very similar. They could be in a single
> patch. And that patch could be the v2 of your previous patch. Just note
> that you have fixed another instance of the same problem in the message
> under the ---.
>
> julia
Thank you Julia!
I am sorry about sending another patch before this one got fixed. I
misundertood and wrongly assumed that someone else had fixed it already.
Sorry about the confusion.
next prev parent reply other threads:[~2023-03-11 9:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 20:52 [PATCH] staging: axis-fifo: alignment should match opening parenthesis in axis-fifo.c Khadija Kamran
2023-03-06 21:08 ` Julia Lawall
[not found] ` <CACcTnM5GR0ZM5WBaL+BDEK_0QJGr6h2t4tnsnjerHta_nq6Tmg@mail.gmail.com>
2023-03-07 7:49 ` Julia Lawall
2023-03-07 8:02 ` Dan Carpenter
2023-03-07 8:07 ` Julia Lawall
2023-03-07 8:14 ` Dan Carpenter
[not found] ` <CACcTnM4OHFiGrEez6dMzd4jO4YuQZzqpUK86UBMzhd+nFDWezA@mail.gmail.com>
2023-03-07 8:13 ` Julia Lawall
2023-03-10 16:01 ` Khadija Kamran
2023-03-11 8:56 ` Julia Lawall
2023-03-11 9:21 ` Khadija Kamran [this message]
2023-03-07 7:13 ` Dan Carpenter
[not found] ` <CACcTnM5kVTG3JaLK9mjaOO7qcXoTrb4xsg2af5Ac1ScqFfbjTg@mail.gmail.com>
2023-03-07 8:18 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAxIDlfL/+n4Pkyo@khadija-virtual-machine \
--to=kamrankhadijadj@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox