From: Simon Horman <simon.horman@corigine.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfc: mrvl: Use of_property_read_bool() for boolean properties
Date: Sat, 11 Mar 2023 12:41:51 +0100 [thread overview]
Message-ID: <ZAxo/8hosiQrcggr@corigine.com> (raw)
In-Reply-To: <20230310144718.1544283-1-robh@kernel.org>
On Fri, Mar 10, 2023 at 08:47:18AM -0600, Rob Herring wrote:
> It is preferred to use typed property access functions (i.e.
> of_property_read_<type> functions) rather than low-level
> of_get_property/of_find_property functions for reading properties.
> Convert reading boolean properties to to of_property_read_bool().
>
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
> ---
> drivers/nfc/nfcmrvl/i2c.c | 2 +-
> drivers/nfc/nfcmrvl/main.c | 6 +-----
> drivers/nfc/nfcmrvl/uart.c | 11 ++---------
> 3 files changed, 4 insertions(+), 15 deletions(-)
...
> diff --git a/drivers/nfc/nfcmrvl/main.c b/drivers/nfc/nfcmrvl/main.c
> index 1a5284de4341..141bc4b66dcb 100644
> --- a/drivers/nfc/nfcmrvl/main.c
> +++ b/drivers/nfc/nfcmrvl/main.c
> @@ -261,11 +261,7 @@ int nfcmrvl_parse_dt(struct device_node *node,
> return reset_n_io;
> }
> pdata->reset_n_io = reset_n_io;
> -
> - if (of_find_property(node, "hci-muxed", NULL))
> - pdata->hci_muxed = 1;
> - else
> - pdata->hci_muxed = 0;
> + pdata->hci_muxed = of_property_read_bool(node, "hci-muxed");
FWIIW, I'm not entirely excited by assigning a bool value
to an integer variable. But I guess that is a challenge for another day.
>
> return 0;
> }
> diff --git a/drivers/nfc/nfcmrvl/uart.c b/drivers/nfc/nfcmrvl/uart.c
> index 9c92cbdc42f0..956ae92f7573 100644
> --- a/drivers/nfc/nfcmrvl/uart.c
> +++ b/drivers/nfc/nfcmrvl/uart.c
> @@ -76,15 +76,8 @@ static int nfcmrvl_uart_parse_dt(struct device_node *node,
> return ret;
> }
>
> - if (of_find_property(matched_node, "flow-control", NULL))
> - pdata->flow_control = 1;
> - else
> - pdata->flow_control = 0;
> -
> - if (of_find_property(matched_node, "break-control", NULL))
> - pdata->break_control = 1;
> - else
> - pdata->break_control = 0;
> + pdata->flow_control = of_property_read_bool(matched_node, "flow-control");
> + pdata->break_control = of_property_read_bool(matched_node, "break-control");
Likewise, here.
> of_node_put(matched_node);
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-03-11 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 14:47 [PATCH] nfc: mrvl: Use of_property_read_bool() for boolean properties Rob Herring
2023-03-11 11:41 ` Simon Horman [this message]
2023-03-13 6:53 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZAxo/8hosiQrcggr@corigine.com \
--to=simon.horman@corigine.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox