Re: comedi

Re: comedi

[Ian Abbott]

On 24/03/2023 11:51, Gary Rookard wrote:
>  From ff0a68124526ea1ac003fbfdd4de47e347881dfe Mon Sep 17 00:00:00 2001
> From: Gary Rookard <garyrookard@linuxmail.org>
> Date: Thu, 23 Mar 2023 16:10:12 -0400
> Subject: [PATCH] Staging: comedi: comedi_fops: fixed missing blank line 
> coding
>   style issues
> 
> Fixed/added 3 blank lines to resolve  issues, comedi_fops is checkpatch 
> clean.
> 
> Signed-off-by: Gary Rookard <garyrookard@linuxmail.org>
> ---
>   drivers/staging/comedi/comedi_fops.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/comedi/comedi_fops.c 
> b/drivers/staging/comedi/comedi_fops.c
> index e85a99b68f31..3f70e5dfac39 100644
> --- a/drivers/staging/comedi/comedi_fops.c
> +++ b/drivers/staging/comedi/comedi_fops.c
> @@ -2169,6 +2169,7 @@ static long comedi_unlocked_ioctl(struct file 
> *file, unsigned int cmd,
>                  break;
>          case COMEDI_CHANINFO: {
>                  struct comedi_chaninfo it;
> +
>                  if (copy_from_user(&it, (void __user *)arg, sizeof(it)))
>                          rc = -EFAULT;
>                  else
> @@ -2177,6 +2178,7 @@ static long comedi_unlocked_ioctl(struct file 
> *file, unsigned int cmd,
>          }
>          case COMEDI_RANGEINFO: {
>                  struct comedi_rangeinfo it;
> +
>                  if (copy_from_user(&it, (void __user *)arg, sizeof(it)))
>                          rc = -EFAULT;
>                  else
> @@ -2249,6 +2251,7 @@ static long comedi_unlocked_ioctl(struct file 
> *file, unsigned int cmd,
>          }
>          case COMEDI_INSN: {
>                  struct comedi_insn insn;
> +
>                  if (copy_from_user(&insn, (void __user *)arg, 
> sizeof(insn)))
>                          rc = -EFAULT;
>                  else
> -- 
> 2.34.1
> 
> Sent from Mailspring

This is already resolved by commit 76cd0c7cc20f ("Staging: comedi: Added 
blank lines to fix coding style issue") in the 5.10 kernel (from the 
year 2020):

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=76cd0c7cc20f3ca71f1be38bfc0c9d3c0807e7ca

-- 
-=( Ian Abbott <abbotti@mev.co.uk> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-

Re: comedi

[greg]

Please don't use html email (the mailing lists reject it) and don't
top-post (makes having technical discussions impossible.)

On Fri, Mar 24, 2023 at 08:25:38AM -0400, Gary Rookard wrote:
> Okay, somehow git cloned an old staging kernel version on me need to figure it out why
> so it doesn't happen again.
> Download date: Wed 22 Mar 2023 08∶59∶26 PM EDT
> Git source: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git
> File in question still had check patch warnings.

You are looking at the wrong branch, ignore the `master` branch in
there, use staging-next please.

thanks,

greg k-h

Re: comedi

[greg]

On Fri, Mar 24, 2023 at 07:51:18AM -0400, Gary Rookard wrote:
> >From ff0a68124526ea1ac003fbfdd4de47e347881dfe Mon Sep 17 00:00:00 2001
> From: Gary Rookard <garyrookard@linuxmail.org>
> Date: Thu, 23 Mar 2023 16:10:12 -0400
> Subject: [PATCH] Staging: comedi: comedi_fops: fixed missing blank line coding
> style issues
> 
> Fixed/added 3 blank lines to resolve issues, comedi_fops is checkpatch clean.
> Signed-off-by: Gary Rookard <garyrookard@linuxmail.org>

As Ian pointed out, this was fixed a very long time ago.  Please always
work against the latest kernel tree so you don't duplicate work that was
already done.

I suggest going through the tutorial on kernelnewbies.org as well, this,
and the previous submission, had a number of problems (hint, this patch
was corrupted and couldn't be applied.)

good luck!

greg k-h