From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C80C1C6FD1C for ; Fri, 24 Mar 2023 17:10:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232010AbjCXRK3 (ORCPT ); Fri, 24 Mar 2023 13:10:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231992AbjCXRKX (ORCPT ); Fri, 24 Mar 2023 13:10:23 -0400 Received: from mail-pj1-x104a.google.com (mail-pj1-x104a.google.com [IPv6:2607:f8b0:4864:20::104a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 320EE21A38 for ; Fri, 24 Mar 2023 10:10:20 -0700 (PDT) Received: by mail-pj1-x104a.google.com with SMTP id o89-20020a17090a0a6200b0023b3d3acdd6so2600463pjo.3 for ; Fri, 24 Mar 2023 10:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679677820; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=vyDS7zcExbdUJKL+EU4Z73G2mWyinpCTeuPFZtODKYE=; b=UOKFh/r2A49LuZpNoYzxruwq0cUWLiB4ILV1YowxrZ7He1LO/2mMPJf7lfbKte7daz ah9gnQS7EOomNLly1ux0KwATpHwRt3vQy93XdyjUFTfKITsCoUhgZsTir+AKiGmjP7b4 +6wTYrEaegTyS9x+Rp6am1FdEFKYNdYZ6aYmR4WhmAU1C52iE2ZIV/GXql9yQRnfaGQ/ 6d4eISlWPolEpTEncTKagZmw7H8f11cs3/d7jCD8UlQQ0BNBArunAaLqEsVvhLVmElOQ ZBEdztZjZvtsm/GENWVZnqjiaor2zRr1Q2d4UDT63RGUbdWQHQgwY/RdPmhS+vfE8jWV yvig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679677820; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vyDS7zcExbdUJKL+EU4Z73G2mWyinpCTeuPFZtODKYE=; b=3EGlnw146s/FcQEgpqpBDndDmhb9skybv+wLR2T2iNdJkR2+gc/sf7hoEs/7c/HLzy 0dXmyl9oHxadmZpU1PSMP5BzqEap9tCNvSe6t2jYZjl+fB5Y5CV0IA1yhVbAsiI38X5Z 4LYdmXzLMS1J4X5TGHwuEl8TN/aO1yINz5eg753cGS6nefXShxxeLNsUuY+c8JYwqT+d QNS7D6X4/vfqMQplMrSgsSt3oI6JKhwvnfzNbtN4hl8fmXY9Fi/x7vjjrfnkM69g08HB k2dK1mcnlO/LsigF1rSyJgp3NQXBhALfjPUm0gd34wkBE1yG90pcSHynN9NSVbgEXOFA KxbQ== X-Gm-Message-State: AAQBX9egNUAFDfPZ29PE2DysCZNr/fe9/9eHufi1FntOt49u1qKTlhCK D/R0b1ma69gWBo5Rl9fX3jc7tD5sLXA= X-Google-Smtp-Source: AKy350a8xIOJAwkNAQ0q4xylGy4UnbU2e+5S+fKOut9r/kh7MGLuj+VxEJRsh//jMz2xLck3pJg/M38ookk= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90a:66cf:b0:23b:446b:bbfd with SMTP id z15-20020a17090a66cf00b0023b446bbbfdmr1097256pjl.1.1679677820315; Fri, 24 Mar 2023 10:10:20 -0700 (PDT) Date: Fri, 24 Mar 2023 10:10:18 -0700 In-Reply-To: <20230110175057.715453-3-pgonda@google.com> Mime-Version: 1.0 References: <20230110175057.715453-1-pgonda@google.com> <20230110175057.715453-3-pgonda@google.com> Message-ID: Subject: Re: [PATCH V6 2/7] KVM: selftests: add hooks for managing protected guest memory From: Sean Christopherson To: Peter Gonda Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Vishal Annapurve , Ackerley Tng , Andrew Jones , Michael Roth Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 10, 2023, Peter Gonda wrote: > Add kvm_vm.protected metadata. Protected VMs memory, potentially > register and other state may not be accessible to KVM. This combined > with a new protected_phy_pages bitmap will allow the selftests to check > if a given pages is accessible. > > Cc: Paolo Bonzini > Cc: Sean Christopherson > Cc: Vishal Annapurve > Cc: Ackerley Tng > cc: Andrew Jones > Originally-by: Michael Roth > Signed-off-by: Peter Gonda > --- > .../selftests/kvm/include/kvm_util_base.h | 14 ++++++++++++-- > tools/testing/selftests/kvm/lib/kvm_util.c | 16 +++++++++++++--- > 2 files changed, 25 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/kvm/include/kvm_util_base.h b/tools/testing/selftests/kvm/include/kvm_util_base.h > index fbc2a79369b8..015b59a0b80e 100644 > --- a/tools/testing/selftests/kvm/include/kvm_util_base.h > +++ b/tools/testing/selftests/kvm/include/kvm_util_base.h > @@ -45,6 +45,7 @@ typedef uint64_t vm_vaddr_t; /* Virtual Machine (Guest) virtual address */ > struct userspace_mem_region { > struct kvm_userspace_memory_region region; > struct sparsebit *unused_phy_pages; > + struct sparsebit *protected_phy_pages; > int fd; > off_t offset; > enum vm_mem_backing_src_type backing_src_type; > @@ -111,6 +112,9 @@ struct kvm_vm { > vm_vaddr_t handlers; > uint32_t dirty_ring_size; > > + /* VM protection enabled: SEV, etc*/ > + bool protected; > + > /* Cache of information for binary stats interface */ > int stats_fd; > struct kvm_stats_header stats_header; > @@ -679,10 +683,16 @@ const char *exit_reason_str(unsigned int exit_reason); > > vm_paddr_t vm_phy_page_alloc(struct kvm_vm *vm, vm_paddr_t paddr_min, > uint32_t memslot); > -vm_paddr_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, > - vm_paddr_t paddr_min, uint32_t memslot); > +vm_paddr_t _vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, Two underscores please. Ignore the terrible precedent that has been set, we're slowly purging that crud. > + vm_paddr_t paddr_min, uint32_t memslot, bool protected); Wrap, no strong justification for running long in this case since the declaration has already wrapped, and the definition does wrap.