From: Greg KH <gregkh@linuxfoundation.org>
To: Khadija Kamran <kamrankhadijadj@gmail.com>
Cc: outreachy@lists.linux.dev, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] staging: rtl8192u: remove change history from comments
Date: Sat, 25 Mar 2023 13:23:55 +0100 [thread overview]
Message-ID: <ZB7n23tzWxGmBPe4@kroah.com> (raw)
In-Reply-To: <c4ec9246e2d103c15e451fe3d6ed42692c93d39f.1679744684.git.kamrankhadijadj@gmail.com>
On Sat, Mar 25, 2023 at 05:13:17PM +0500, Khadija Kamran wrote:
> Developers use git to browse the file history so revision history is not
> required in the comments.
> Remove the change history information from the comments.
>
> Signed-off-by: Khadija Kamran <kamrankhadijadj@gmail.com>
> ---
> drivers/staging/rtl8192u/r8192U_dm.c | 36 ----------------------------
> 1 file changed, 36 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> index a88686be3523..885c5966342f 100644
> --- a/drivers/staging/rtl8192u/r8192U_dm.c
> +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> @@ -8,11 +8,6 @@
> * Abstract:
> * HW dynamic mechanism.
> *
> - * Major Change History:
> - * When Who What
> - * ---------- --------------- -------------------------------
> - * 2008-05-14 amy create version 0 porting from windows code.
> - *
> *--
> */
> #include "r8192U.h"
> @@ -276,10 +271,6 @@ void init_rate_adaptive(struct net_device *dev)
> *
> * Return: NONE
> *
> - * Revised History:
> - * When Who Remark
> - * 05/26/08 amy Create version 0 porting from windows code.
> - *
> *---------------------------------------------------------------------------
You can remove the extra blank comment line as well.
thanks,
greg k-h
next prev parent reply other threads:[~2023-03-25 12:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 12:13 [PATCH 0/3] staging: rtl8192u: clean up comments in r8192U_dm.c Khadija Kamran
2023-03-25 12:13 ` [PATCH 1/3] staging: rtl8192u: reformat block comments Khadija Kamran
2023-03-25 12:23 ` Greg KH
2023-03-25 12:31 ` Khadija Kamran
2023-03-25 12:13 ` [PATCH 2/3] staging: rtl8192u: remove change history from comments Khadija Kamran
2023-03-25 12:23 ` Greg KH [this message]
2023-03-25 14:04 ` Julia Lawall
2023-03-25 12:13 ` [PATCH 3/3] staging: rtl8192u: remove code " Khadija Kamran
2023-03-25 12:22 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB7n23tzWxGmBPe4@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kamrankhadijadj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox