From: Mark Brown <broonie@kernel.org>
To: "Ye, Xiang" <xiang.ye@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Matthias Kaehlcke <mka@chromium.org>, Lee Jones <lee@kernel.org>,
Wolfram Sang <wsa@kernel.org>, Tyrone Ting <kfting@nuvoton.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-gpio@vger.kernel.org, srinivas.pandruvada@intel.com,
heikki.krogerus@linux.intel.com,
andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
zhifeng.wang@intel.com, wentong.wu@intel.com,
lixu.zhang@intel.com
Subject: Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device
Date: Sat, 25 Mar 2023 18:05:09 +0000 [thread overview]
Message-ID: <ZB831a6F4A7qufqs@sirena.org.uk> (raw)
In-Reply-To: <ZB8u3wWTQhg4PvQe@ye-NUC7i7DNHE>
[-- Attachment #1: Type: text/plain, Size: 774 bytes --]
On Sun, Mar 26, 2023 at 01:26:55AM +0800, Ye, Xiang wrote:
> On Sat, Mar 25, 2023 at 05:20:09PM +0100, Greg Kroah-Hartman wrote:
> > As this requires ACPI, why are you not saying so in your Kconfig entry?
> I would add a `depends on ACPI` item on the Kconfig entry so that the
> CONFI_ACPI macro can be removed from usb-ljca, because our use case with
> LJCA currently needs the ACPI binding.
> > What good would this driver be without ACPI enabled?
> Before, I just tried to make it compatible with other platforms that
> don't support ACPI but want to use LJCA device. But, We don't have
> this use case until now.
If it builds without ACPI then making the dependency ACPI ||
COMPILE_TEST will help improve build coverage for people doing
treewide or subsystem work.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2023-03-25 18:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-25 15:47 [PATCH v7 0/6] Add Intel LJCA device driver Ye Xiang
2023-03-25 15:47 ` [PATCH v7 1/6] usb: Add support for Intel LJCA device Ye Xiang
2023-03-25 16:20 ` Greg Kroah-Hartman
2023-03-25 17:26 ` Ye, Xiang
2023-03-25 17:35 ` Greg Kroah-Hartman
2023-03-25 18:05 ` Mark Brown [this message]
2023-03-25 22:27 ` Greg Kroah-Hartman
2023-03-26 9:04 ` Ye, Xiang
2023-03-27 11:08 ` Oliver Neukum
2023-03-25 15:47 ` [PATCH v7 2/6] usb: ljca: Add transport interfaces for sub-module drivers Ye Xiang
2023-03-25 15:47 ` [PATCH v7 3/6] Documentation: Add ABI doc for attributes of LJCA device Ye Xiang
2023-04-04 8:53 ` Oliver Neukum
2023-04-10 10:44 ` Ye, Xiang
2023-04-12 11:10 ` Oliver Neukum
2023-03-25 15:47 ` [PATCH v7 4/6] gpio: Add support for Intel LJCA USB GPIO driver Ye Xiang
2023-03-29 8:37 ` Linus Walleij
2023-03-25 15:47 ` [PATCH v7 5/6] i2c: Add support for Intel LJCA USB I2C driver Ye Xiang
2023-03-25 15:47 ` [PATCH v7 6/6] spi: Add support for Intel LJCA USB SPI driver Ye Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZB831a6F4A7qufqs@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kfting@nuvoton.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=mka@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@intel.com \
--cc=wentong.wu@intel.com \
--cc=wsa@kernel.org \
--cc=xiang.ye@intel.com \
--cc=zhifeng.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox