From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0387C6FD1C for ; Sat, 25 Mar 2023 22:27:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231667AbjCYW1M (ORCPT ); Sat, 25 Mar 2023 18:27:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229460AbjCYW1K (ORCPT ); Sat, 25 Mar 2023 18:27:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F79E7ECF; Sat, 25 Mar 2023 15:27:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7452560DB9; Sat, 25 Mar 2023 22:27:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 42DA0C433D2; Sat, 25 Mar 2023 22:27:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1679783226; bh=Q1bKTClEuBaOpbRZAO3AJ33e5TyraS8c50q00hE8OrM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U+6nM9g0zg7W2kYLAN9MJ/gl+50xPyW1wq7KwPEk1OaOcaEUCfzrIEhb15Sy1taM/ i5fnBonLNHyFVCgWHCvsLTFbKy2pp24iQVny7NtTIuhxEsL/WCQaVkKQl0oCln4g4U ewnEBpMoZW1VqyW9QPvp1ZtY8kTvH9zt2XIVkync= Date: Sat, 25 Mar 2023 23:27:03 +0100 From: Greg Kroah-Hartman To: Ye Xiang Cc: Arnd Bergmann , Matthias Kaehlcke , Lee Jones , Wolfram Sang , Tyrone Ting , Mark Brown , Linus Walleij , Bartosz Golaszewski , linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-gpio@vger.kernel.org, srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com, andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com, zhifeng.wang@intel.com, wentong.wu@intel.com, lixu.zhang@intel.com Subject: Re: [PATCH v7 1/6] usb: Add support for Intel LJCA device Message-ID: References: <20230325154711.2419569-1-xiang.ye@intel.com> <20230325154711.2419569-2-xiang.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230325154711.2419569-2-xiang.ye@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 25, 2023 at 11:47:06PM +0800, Ye Xiang wrote: > +static void ljca_aux_release(struct device *dev) {} Sorry, but creating an empty release function just to shut the kernel up is NOT how to properly do this, you all know better. This is totally broken. The kernel was telling you what you had to do, don't think that you are being smarter than it by doing this, otherwise we would have never had the kernel spit out that error in the first place, right? Now I will ask you to follow the proper Intel kernel review rules and get proper approval for the patchset before submitting it to us again, as basic things like this are not supposed to be caught by us, but by your internal review process first. good luck! greg k-h