From: Johan Hovold <johan@kernel.org>
To: Georgi Djakov <djakov@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Yassine Oudjana <y.oudjana@protonmail.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] interconnect: qcom: rpm: drop bogus pm domain attach
Date: Tue, 14 Mar 2023 08:46:53 +0100 [thread overview]
Message-ID: <ZBAmbYxztGTK0vHV@hovoldconsulting.com> (raw)
In-Reply-To: <eb633e38-7972-4655-63d1-80399bb3a80b@kernel.org>
On Mon, Mar 13, 2023 at 09:58:24PM +0200, Georgi Djakov wrote:
> Hi Johan,
>
> On 13.03.23 10:49, Johan Hovold wrote:
> > Any power domain would already have been attached by the platform bus
> > code so drop the bogus power domain attach which always succeeds from
> > probe.
> >
> > This effectively reverts commit 7de109c0abe9 ("interconnect: icc-rpm:
> > Add support for bus power domain").
> >
> > Fixes: 7de109c0abe9 ("interconnect: icc-rpm: Add support for bus power domain")
> > Cc: Yassine Oudjana <y.oudjana@protonmail.com>
> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> To make it a complete revert, I'll fold this in:
>
> diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c
> index 0badd2c75161..c80819557923 100644
> --- a/drivers/interconnect/qcom/icc-rpm.c
> +++ b/drivers/interconnect/qcom/icc-rpm.c
> @@ -11,7 +11,6 @@
> #include <linux/of_device.h>
> #include <linux/of_platform.h>
> #include <linux/platform_device.h>
> -#include <linux/pm_domain.h>
> #include <linux/regmap.h>
> #include <linux/slab.h>
Thanks for catching that!
Johan
next prev parent reply other threads:[~2023-03-14 7:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 8:49 [PATCH 0/2] interconnect: qcom: rpm: fix msm8996 interconnect registration Johan Hovold
2023-03-13 8:49 ` [PATCH 1/2] " Johan Hovold
2023-03-13 8:57 ` Konrad Dybcio
2023-03-13 9:11 ` Johan Hovold
2023-03-13 8:49 ` [PATCH 2/2] interconnect: qcom: rpm: drop bogus pm domain attach Johan Hovold
2023-03-13 9:10 ` Konrad Dybcio
2023-03-13 19:58 ` Georgi Djakov
2023-03-14 7:46 ` Johan Hovold [this message]
2023-03-13 19:57 ` [PATCH 0/2] interconnect: qcom: rpm: fix msm8996 interconnect registration Georgi Djakov
2023-03-14 7:45 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBAmbYxztGTK0vHV@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=y.oudjana@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox