From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Jens Axboe <axboe@kernel.dk>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] spi: docs: adjust summary to CONFIG_SYSFS_DEPRECATED removal
Date: Tue, 14 Mar 2023 09:03:41 +0100 [thread overview]
Message-ID: <ZBAqXXGnqJmySgkM@kroah.com> (raw)
In-Reply-To: <20230314075609.5232-1-lukas.bulwahn@gmail.com>
On Tue, Mar 14, 2023 at 08:56:09AM +0100, Lukas Bulwahn wrote:
> With commit 721da5cee9d4 ("driver core: remove CONFIG_SYSFS_DEPRECATED and
> CONFIG_SYSFS_DEPRECATED_V2"), ./scripts/checkkconfigsymbols.py indicated
> an unresolved reference to the config SYSFS_DEPRECATED in the SPI summary
> documentation.
>
> Simply, delete the sentence referring to the removed config there. Also
> update the documentation, as these sys/class entries should always be
> symlinks, as the commit message of the commit above suggests.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
> Mark, Greg, Jens, please confirm that these sys/class entries now always
> are symlinks. That is simply my guess after reading a bit on sysfs_deprecated
> also changed compared to the normal setup, but I am not the expert here.
They have been symlinks for years, the only subsystem that the
CONFIG_SYSFS_DEPRECATED logic still modified was for the block
subsystem. So your change looks good to me, thanks for doing this:
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2023-03-14 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 7:56 [PATCH] spi: docs: adjust summary to CONFIG_SYSFS_DEPRECATED removal Lukas Bulwahn
2023-03-14 8:03 ` Greg Kroah-Hartman [this message]
2023-03-14 8:14 ` Lukas Bulwahn
2023-03-14 15:28 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBAqXXGnqJmySgkM@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox