Re: [PATCH 4/3] KVM: x86/xen: Make runstate cache gpcs share a lock

David Woodhouse
2023-01-31T16:58:56Z

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

(resending from non-broken system)

On Mon, 2023-01-30 at 14:25 +0900, David Stevens wrote:
> From: David Stevens <stevensd@chromium.org>
>
> Simplify locking in the case where the guest's runstate_info is split
> across two pages by sharing a single lock for the two gpcs.
>
> Signed-off-by: David Stevens <stevensd@chromium.org>
> ---
> I tested this patch with xen_shinfo_test as suggested, and it still
> passes. I agree that it makes sense to do this as a seperate patch. For
> the bot reported issue, looks like I forgot to build with lockdep
> enabled. I'll fix the issue with that patch in the next revision of the
> series, so that there aren't any commits which don't build.

Ack. Running actual Xen guests also works (but it's the xen_shinfo_test
which is going to exercise cross-page runstate and is most
interesting).

Tested-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-By: David Woodhouse <dwmw@amazon.co.uk>

[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5965 bytes --]