Re: [PATCH v2 1/4] blk-integrity: use sysfs_emit

Christoph Hellwig
2023-03-15T15:01:43Z

> if (bi->profile && bi->profile->name)
> - return sprintf(page, "%s\n", bi->profile->name);
> + return sysfs_emit(page, "%s\n", bi->profile->name);
> else

Might be worth to drop the else here if you touch the function.

>
> + return sysfs_emit(page, "%d\n", (bi->flags & BLK_INTEGRITY_VERIFY) != 0);

Please shorten these != 0 to !! expressions, i.e.

return sysfs_emit(page, "%d\n", !!(bi->flags & BLK_INTEGRITY_VERIFY));