[PATCH v5 00/16] perf kvm: Support histograms and TUI mode

Leo Yan
2023-03-15T14:51:36Z

This patch set is to enable histograms and (partially) TUI mode in perf
kvm tool; patch set v1 [1] gives brief introduction for the change.

We can use below commands for testing this series:

In a terminal, you could launch a virtual machine with qemu command; in
below case, I downloaded a Ubuntu (or Debian) iso file and used it as
the file system image:

$ qemu-system-x86_64 -M pc -enable-kvm -cpu host -m 4096 -hda ubuntu-22.04-desktop-amd64.iso

Then in another terminal, I can use below command to capture KVM trace
data and report the result:

# cd linux/tools/perf
# ./perf kvm stat record
# ./perf kvm stat report => Output in TUI mode
# ./perf kvm stat report --stdio => Output in stdio mode

Changes from v4:
* Fixed building failure in patch 04; compiled successfully for every
patch to ensure bisection.

Changes from v3:
* Updated patch 04 to change comparison function return type from int to
int64_t to avoid overflow;
* Added a refactoring patch 05 "perf kvm: Use macro to replace variable
'decode_str_len'";
* Refined to use hists__add_entry_ops() and hist_entry__cmp() to compare
hist entry and add new entries, to support comparison between hist
entry, added a new patch 09; (Namhyung Kim)
* Updated patch 10 for comparison event name; (Namhyung Kim)
* Refined patch 11 to move init_stats() and hists__inc_nr_samples()
into kvm_he_zalloc(); (Namhyung Kim)
* Minor refactoring for sort_result() and kvm_hists__init() in patch 15.

Changes from v2:
* Found building failure with command 'make VF=1 DEBUG=1 NO_SLANG=1',
fixed it in the patch 13. (James Clark)

Changes from v1:
* Updated the patch 13 'perf kvm: Add TUI mode for stat report' to avoid
building failure if no support HAVE_SLANG_SUPPORT.

[1] https://lore.kernel.org/lkml/20230226042053.1492409-1-leo.yan@linaro.org/

Leo Yan (16):
perf kvm: Refactor overall statistics
perf kvm: Add pointer to 'perf_kvm_stat' in kvm event
perf kvm: Move up metrics helpers
perf kvm: Use subtraction for comparison metrics
perf kvm: Use macro to replace variable 'decode_str_len'
perf kvm: Introduce histograms data structures
perf kvm: Pass argument 'sample' to kvm_alloc_init_event()
perf kvm: Parse address location for samples
perf hist: Add 'kvm_info' field in histograms entry
perf kvm: Add dimensions for KVM event statistics
perf kvm: Use histograms list to replace cached list
perf kvm: Polish sorting key
perf kvm: Support printing attributions for dimensions
perf kvm: Add dimensions for percentages
perf kvm: Add TUI mode for stat report
perf kvm: Update documentation to reflect new changes

tools/perf/Documentation/perf-kvm.txt | 9 +-
tools/perf/arch/arm64/util/kvm-stat.c | 1 -
tools/perf/arch/powerpc/util/kvm-stat.c | 3 +-
tools/perf/arch/s390/util/kvm-stat.c | 1 -
tools/perf/arch/x86/util/kvm-stat.c | 7 +-
tools/perf/builtin-annotate.c | 2 +-
tools/perf/builtin-c2c.c | 4 +-
tools/perf/builtin-diff.c | 4 +-
tools/perf/builtin-kvm.c | 859 +++++++++++++++++++-----
tools/perf/tests/hists_link.c | 4 +-
tools/perf/util/hist.c | 19 +-
tools/perf/util/hist.h | 3 +
tools/perf/util/kvm-stat.h | 33 +-
tools/perf/util/sort.h | 1 +
14 files changed, 745 insertions(+), 205 deletions(-)

--
2.34.1