From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kurt Kanzenbach <kurt@linutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v6 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get()
Date: Thu, 16 Mar 2023 09:11:23 +0100 [thread overview]
Message-ID: <ZBLPK0loejiHEoe5@localhost.localdomain> (raw)
In-Reply-To: <ZBHFOlwoLYn3xz2L@smile.fi.intel.com>
On Wed, Mar 15, 2023 at 03:16:42PM +0200, Andy Shevchenko wrote:
> On Wed, Mar 15, 2023 at 06:57:37AM +0100, Michal Swiatkowski wrote:
> > On Tue, Mar 14, 2023 at 08:18:24PM +0200, Andy Shevchenko wrote:
> > > LED core provides a helper to parse default state from firmware node.
> > > Use it instead of custom implementation.
>
> ...
>
> > You have to fix implict declaration of the led_init_default_state_get().
>
> Seems like users have to choose between 'select NEW_LEDS' and
> 'depends on NEW_LEDS' in the Kconfig.
>
> > I wonder if the code duplication here can be avoided:
>
> Whether or not this is out of the scope of this patch.
> Feel free to submit one :-)
>
> ...
>
Reasonable ;)
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
> > Only suggestion, patch looks good.
>
> Thank you!
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2023-03-16 8:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 18:18 [PATCH net-next v6 1/1] net: dsa: hellcreek: Get rid of custom led_init_default_state_get() Andy Shevchenko
2023-03-15 1:05 ` kernel test robot
2023-03-15 17:06 ` Andy Shevchenko
2023-03-15 19:51 ` Nathan Chancellor
2023-03-15 21:15 ` Jakub Kicinski
2023-03-16 1:48 ` Philip Li
2023-03-15 5:57 ` Michal Swiatkowski
2023-03-15 13:16 ` Andy Shevchenko
2023-03-16 8:11 ` Michal Swiatkowski [this message]
2023-03-15 17:07 ` Andy Shevchenko
2023-03-17 0:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBLPK0loejiHEoe5@localhost.localdomain \
--to=michal.swiatkowski@linux.intel.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox