From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Florian Fainelli <f.fainelli@gmail.com>,
Steve Glendinning <steve.glendinning@shawell.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Revert "net: smsc911x: Make Runtime PM handling more fine-grained"
Date: Fri, 17 Mar 2023 06:00:24 +0100 [thread overview]
Message-ID: <ZBPz6Ads0dOT8ceT@ninjato> (raw)
In-Reply-To: <CAMuHMdURZ-nC-yZua1wGCcW++fDhgd-U93KP3PT5v6cbm8305A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 367 bytes --]
Hi Geert,
> In sh_eth this was fixed differently, by adding a check for
> mdp->is_opened to sh_eth_get_stats() [1].
> I believe the modern way would be to add a check for netif_running()
> instead.
>
> Would adding such a check to smsc911x_get_stats() work for you, too?
Yeah, that worked. Thank you! I'll send v2 soon.
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-03-17 5:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 7:45 [PATCH net 0/2] smsc: fix bugs when interface is not up Wolfram Sang
2023-03-16 7:45 ` [PATCH 1/2] Revert "net: smsc911x: Make Runtime PM handling more fine-grained" Wolfram Sang
2023-03-16 9:07 ` Geert Uytterhoeven
2023-03-17 5:00 ` Wolfram Sang [this message]
2023-03-16 7:45 ` [PATCH 2/2] smsc911x: avoid PHY being resumed when interface is not up Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBPz6Ads0dOT8ceT@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steve.glendinning@shawell.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox