Re: [PATCH net-next v3 7/9] net: sunhme: Clean up mac address init

Simon Horman
2023-03-21T08:02:01Z

On Sat, Mar 18, 2023 at 11:43:16AM -0400, Sean Anderson wrote:
> On 3/18/23 05:03, Simon Horman wrote:
> > On Mon, Mar 13, 2023 at 08:36:11PM -0400, Sean Anderson wrote:
> > > Clean up some oddities suggested during review.
> > >
> > > Signed-off-by: Sean Anderson <seanga2@gmail.com>

...

> > > @@ -2386,7 +2385,7 @@ static void __maybe_unused get_hme_mac_nonsparc(struct pci_dev *pdev,
> > > dev_addr[2] = 0x20;
> > > get_random_bytes(&dev_addr[3], 3);
> > > }
> > > -#endif /* !(CONFIG_SPARC) */
> > > +#endif
> >
> > Hi Sean,
> >
> > I think this problem was added by patch 6/9,
> > so perhaps best to squash it into that patch.
>
> > Actually, I'd squash all these changes into 6/9.
> > But I don't feel strongly about it.
>
> 6/9 just moves code around. I am keeping the modifications for other commits.

Ack.