Re: [PATCH 2/3] iio: accel: kionix-kx022a: Add chip_info structure

Andy Shevchenko
2023-03-17T12:07:06Z

On Fri, Mar 17, 2023 at 12:48:36AM +0100, Mehdi Djait wrote:
> Refactor the kx022a driver implementation to make it more
> generic and extensible.
> Add the chip_info structure will to the driver's private
> data to hold all the device specific infos.
> Move the enum, struct and constants definitions to the header
> file.

Please, compile and test before sending.

...

> .driver = {
> - .name = "kx022a-spi",
> + .name = "kx022a-spi",
> .of_match_table = kx022a_of_match,
> },

What was changed here?

...

> - .id_table = kx022a_id,
> + .id_table = kx022a_spi_id,

Why do we need this change?

...

> - name = devm_kasprintf(data->dev, GFP_KERNEL, "%s-kx022a",
> + name = devm_kasprintf(data->dev, GFP_KERNEL, "%s-accel",
> dev_name(data->dev));

Shouldn't you use the name from chip info?

...

> +#define KX_MASK_BRES16 BIT(6)
> +
> +

One blank line is enough.

> #define KX022A_REG_WHO 0x0f
> #define KX022A_ID 0xc8

--
With Best Regards,
Andy Shevchenko