From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: linux-iio@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Jonathan Cameron <jic23@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] counter: 104-quad-8: Utilize helper functions to handle PR, FLAG and PSC
Date: Mon, 20 Mar 2023 14:28:31 +0200 [thread overview]
Message-ID: <ZBhRb+v/8+vSwjz6@smile.fi.intel.com> (raw)
In-Reply-To: <71496f9295e68388ce07f3051bf5882177be83c5.1679149543.git.william.gray@linaro.org>
On Sat, Mar 18, 2023 at 10:59:51AM -0400, William Breathitt Gray wrote:
> The Preset Register (PR), Flag Register (FLAG), and Filter Clock
> Prescaler (PSC) have common usage patterns. Wrap up such usage into
> dedicated functions to improve code clarity.
...
> +static void quad8_preset_register_set(struct quad8 *const priv, const size_t id,
> + const unsigned long preset)
> +{
> + struct channel_reg __iomem *const chan = priv->reg->channel + id;
> + int i;
> +
> + /* Reset Byte Pointer */
> + iowrite8(SELECT_RLD | RESET_BP, &chan->control);
> +
> + /* Set Preset Register */
> + for (i = 0; i < 3; i++)
> + iowrite8(preset >> (8 * i), &chan->data);
> +}
May we add generic __iowrite8_copy() / __ioread8_copy() instead?
It seems that even current __ioread32_copy() and __iowrite32_copy() has to
be amended to support IO.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-03-20 12:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 14:59 [PATCH 0/4] Refactor 104-quad-8 to match device operations William Breathitt Gray
2023-03-18 14:59 ` [PATCH 1/4] counter: 104-quad-8: Utilize bitfield access macros William Breathitt Gray
2023-03-18 14:59 ` [PATCH 2/4] bitfield: Introduce the FIELD_MODIFY() macro William Breathitt Gray
2023-03-20 8:50 ` Johannes Berg
2023-03-20 12:22 ` Andy Shevchenko
2023-03-20 15:03 ` William Breathitt Gray
2023-03-18 14:59 ` [PATCH 3/4] counter: 104-quad-8: Refactor to buffer states for CMR, IOR, and IDR William Breathitt Gray
2023-03-18 14:59 ` [PATCH 4/4] counter: 104-quad-8: Utilize helper functions to handle PR, FLAG and PSC William Breathitt Gray
2023-03-20 12:28 ` Andy Shevchenko [this message]
2023-03-20 15:31 ` William Breathitt Gray
2023-03-20 15:36 ` Andy Shevchenko
2023-03-20 15:53 ` William Breathitt Gray
2023-03-20 16:54 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBhRb+v/8+vSwjz6@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=jic23@kernel.org \
--cc=johannes.berg@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox