From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: William Breathitt Gray <william.gray@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 0/2] regmap-irq: Drop map from handle_mask_sync() parameters
Date: Mon, 20 Mar 2023 16:45:00 +0200 [thread overview]
Message-ID: <ZBhxbAlvjplGcAie@smile.fi.intel.com> (raw)
In-Reply-To: <ZBd8PZa0kCcG4MQD@fedora>
On Sun, Mar 19, 2023 at 05:18:53PM -0400, William Breathitt Gray wrote:
> On Mon, Mar 20, 2023 at 02:44:43PM +0200, Andy Shevchenko wrote:
> > On Sun, Mar 19, 2023 at 05:02:00PM -0400, William Breathitt Gray wrote:
> > > Changes in v2:
> > > - Pull out 104-dio-48e refactor to a precursor patch
> > >
> > > Remove the map parameter from the struct regmap_irq_chip callback
> > > handle_mask_sync() because it can be passed via the irq_drv_data
> > > parameter instead. The gpio-104-dio-48e driver is the only consumer of
> > > this callback and is thus updated accordingly.
> > >
> > > A couple pending patchsets also utilize handle_mask_sync() [0][1], so
> > > it'll be useful to merge the changes in this series first to avoid
> > > subsequent noise adjusting the dependent drivers.
> > >
> > > [0] https://lore.kernel.org/r/cover.1677515341.git.william.gray@linaro.org/
> > > [1] https://lore.kernel.org/r/cover.1678106722.git.william.gray@linaro.org/
> >
> > Good idea and intention, but something went wrong with bisectability as pointed
> > out by the build bot. As a last resort you would need to squash these two, but
> > try first another possible patch series split.
> I should have build tested each commit when I rebased rather than just
> the last.
Right, that's what we call a "compile time bisectability".
> I'd rather avoid a squash so that these changes are distinct
> for the sake of a clear git history on the regmap API change;
That's my point! I glad we are on the same page.
> I'll submit a v3 soon with the minor changes needed.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-03-20 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 21:02 [PATCH v2 0/2] regmap-irq: Drop map from handle_mask_sync() parameters William Breathitt Gray
2023-03-19 21:02 ` [PATCH v2 1/2] gpio: 104-dio-48e: Implement struct dio48e_gpio William Breathitt Gray
2023-03-20 0:18 ` kernel test robot
2023-03-19 21:02 ` [PATCH v2 2/2] regmap-irq: Drop map from handle_mask_sync() parameters William Breathitt Gray
2023-03-19 21:22 ` [PATCH v2 0/2] " Linus Walleij
2023-03-20 12:44 ` Andy Shevchenko
2023-03-19 21:18 ` William Breathitt Gray
2023-03-20 14:45 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBhxbAlvjplGcAie@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox