Re: [PATCH 5.10 00/99] 5.10.176-rc1 review

David Gow
2023-03-21T04:08:23Z

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

On Tue, 21 Mar 2023 at 03:41, Pavel Machek <pavel@denx.de> wrote:
>
> Hi!
>
> > This is the start of the stable review cycle for the 5.10.176 release.
> > There are 99 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
>
> > David Gow <davidgow@google.com>
> > rust: arch/um: Disable FP/SIMD instruction to match x86
>
> Why is this patch here? It does not make sense for stable, it was only
> in AUTOSEL for less than a week, and I already explained why it is
> bad.
>
> "git grep KBUILD_RUSTFLAGS" if in doubt.

I agree: let's exclude this patch from -stable.

While the CFLAGS part of it is still _technically_ valid without Rust,
it turns out it triggers a bug in gcc <11, so is probably best
avoided. See:
- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99652
- https://lore.kernel.org/linux-um/20230318041555.4192172-1-davidgow@google.com/

Cheers,
-- David

>
> Best regards,
> Pavel
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4003 bytes --]