From: William Breathitt Gray <william.gray@linaro.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: addac: stx104: Migrate to the regmap API
Date: Mon, 20 Mar 2023 12:35:05 -0400 [thread overview]
Message-ID: <ZBiLOWI+0JIWv6BC@fedora> (raw)
In-Reply-To: <ZBiBBJOmjOAHGUn0@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
On Mon, Mar 20, 2023 at 05:51:32PM +0200, Andy Shevchenko wrote:
> On Sun, Mar 19, 2023 at 04:22:56PM -0400, William Breathitt Gray wrote:
> > The regmap API supports IO port accessors so we can take advantage of
> > regmap abstractions rather than handling access to the device registers
> > directly in the driver.
>
> ...
>
> > -/**
> > - * struct stx104_iio - IIO device private data structure
>
> I believe this...
>
> > - * @chan_out_states: channels' output states
> > - * @reg: I/O address offset for the device registers
> > - */
>
> > -struct stx104_iio {
>
> ...and this can be left here. With that the diff won't be too disrupted.
You're right Andy, I'll adjust this in v2 so the diff becomes clearer
(along with some bitfield API adjustments).
William Breathitt Gray
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2023-03-20 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-19 20:22 [PATCH] iio: addac: stx104: Migrate to the regmap API William Breathitt Gray
2023-03-20 15:51 ` Andy Shevchenko
2023-03-20 16:35 ` William Breathitt Gray [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBiLOWI+0JIWv6BC@fedora \
--to=william.gray@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox