From: Simon Horman <simon.horman@corigine.com>
To: Sean Anderson <seanga2@gmail.com>
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 7/9] net: sunhme: Clean up mac address init
Date: Tue, 21 Mar 2023 09:01:43 +0100 [thread overview]
Message-ID: <ZBlkZxOxxfFnIMyu@corigine.com> (raw)
In-Reply-To: <7389fef5-8fe8-4f24-f762-4f3597ad0943@gmail.com>
On Sat, Mar 18, 2023 at 11:43:16AM -0400, Sean Anderson wrote:
> On 3/18/23 05:03, Simon Horman wrote:
> > On Mon, Mar 13, 2023 at 08:36:11PM -0400, Sean Anderson wrote:
> > > Clean up some oddities suggested during review.
> > >
> > > Signed-off-by: Sean Anderson <seanga2@gmail.com>
...
> > > @@ -2386,7 +2385,7 @@ static void __maybe_unused get_hme_mac_nonsparc(struct pci_dev *pdev,
> > > dev_addr[2] = 0x20;
> > > get_random_bytes(&dev_addr[3], 3);
> > > }
> > > -#endif /* !(CONFIG_SPARC) */
> > > +#endif
> >
> > Hi Sean,
> >
> > I think this problem was added by patch 6/9,
> > so perhaps best to squash it into that patch.
>
> > Actually, I'd squash all these changes into 6/9.
> > But I don't feel strongly about it.
>
> 6/9 just moves code around. I am keeping the modifications for other commits.
Ack.
next prev parent reply other threads:[~2023-03-21 8:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 0:36 [PATCH net-next v3 0/9] net: sunhme: Probe/IRQ cleanups Sean Anderson
2023-03-14 0:36 ` [PATCH net-next v3 1/9] net: sunhme: Just restart autonegotiation if we can't bring the link up Sean Anderson
2023-03-15 8:20 ` Simon Horman
2023-03-15 15:35 ` Sean Anderson
2023-03-15 15:57 ` Simon Horman
2023-03-15 15:58 ` Simon Horman
2023-03-18 8:37 ` Simon Horman
2023-03-18 14:31 ` Sean Anderson
2023-03-14 0:36 ` [PATCH net-next v3 2/9] net: sunhme: Remove residual polling code Sean Anderson
2023-03-15 15:58 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 3/9] net: sunhme: Unify IRQ requesting Sean Anderson
2023-03-15 15:59 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 4/9] net: sunhme: Alphabetize includes Sean Anderson
2023-03-15 15:59 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 5/9] net: sunhme: Switch SBUS to devres Sean Anderson
2023-03-18 8:23 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 6/9] net: sunhme: Consolidate mac address initialization Sean Anderson
2023-03-18 8:58 ` Simon Horman
2023-03-18 9:00 ` Simon Horman
2023-03-18 15:31 ` Sean Anderson
2023-03-14 0:36 ` [PATCH net-next v3 7/9] net: sunhme: Clean up mac address init Sean Anderson
2023-03-18 9:03 ` Simon Horman
2023-03-18 15:43 ` Sean Anderson
2023-03-21 8:01 ` Simon Horman [this message]
2023-03-14 0:36 ` [PATCH net-next v3 8/9] net: sunhme: Inline error returns Sean Anderson
2023-03-15 7:51 ` Jakub Kicinski
2023-03-15 15:36 ` Sean Anderson
2023-03-18 13:49 ` Simon Horman
2023-03-14 0:36 ` [PATCH net-next v3 9/9] net: sunhme: Consolidate common probe tasks Sean Anderson
2023-03-18 13:53 ` Simon Horman
2023-03-18 14:40 ` Sean Anderson
2023-03-21 8:00 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBlkZxOxxfFnIMyu@corigine.com \
--to=simon.horman@corigine.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=seanga2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox