* [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function
@ 2023-03-19 4:19 Lizhe
2023-03-20 14:47 ` Anthony Krowiak
2023-03-21 13:41 ` Heiko Carstens
0 siblings, 2 replies; 3+ messages in thread
From: Lizhe @ 2023-03-19 4:19 UTC (permalink / raw)
To: akrowiak, pasic, jjherne, freude, hca, gor, agordeev, borntraeger,
svens
Cc: linux-s390, linux-kernel, Lizhe
If there is no driver match function, the driver core assumes that each
candidate pair (driver, device) matches, see driver_match_device().
Drop the matrix bus's match function that always returned 1 and so
implements the same behaviour as when there is no match function
Signed-off-by: Lizhe <sensor1010@163.com>
---
drivers/s390/crypto/vfio_ap_drv.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
index 997b524bdd2b..9341c000da41 100644
--- a/drivers/s390/crypto/vfio_ap_drv.c
+++ b/drivers/s390/crypto/vfio_ap_drv.c
@@ -59,14 +59,8 @@ static void vfio_ap_matrix_dev_release(struct device *dev)
kfree(matrix_dev);
}
-static int matrix_bus_match(struct device *dev, struct device_driver *drv)
-{
- return 1;
-}
-
static struct bus_type matrix_bus = {
.name = "matrix",
- .match = &matrix_bus_match,
};
static struct device_driver matrix_driver = {
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function
2023-03-19 4:19 [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function Lizhe
@ 2023-03-20 14:47 ` Anthony Krowiak
2023-03-21 13:41 ` Heiko Carstens
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Krowiak @ 2023-03-20 14:47 UTC (permalink / raw)
To: Lizhe, pasic, jjherne, freude, hca, gor, agordeev, borntraeger,
svens
Cc: linux-s390, linux-kernel
Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
On 3/19/23 12:19 AM, Lizhe wrote:
> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device().
>
> Drop the matrix bus's match function that always returned 1 and so
> implements the same behaviour as when there is no match function
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
> drivers/s390/crypto/vfio_ap_drv.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
> index 997b524bdd2b..9341c000da41 100644
> --- a/drivers/s390/crypto/vfio_ap_drv.c
> +++ b/drivers/s390/crypto/vfio_ap_drv.c
> @@ -59,14 +59,8 @@ static void vfio_ap_matrix_dev_release(struct device *dev)
> kfree(matrix_dev);
> }
>
> -static int matrix_bus_match(struct device *dev, struct device_driver *drv)
> -{
> - return 1;
> -}
> -
> static struct bus_type matrix_bus = {
> .name = "matrix",
> - .match = &matrix_bus_match,
> };
>
> static struct device_driver matrix_driver = {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function
2023-03-19 4:19 [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function Lizhe
2023-03-20 14:47 ` Anthony Krowiak
@ 2023-03-21 13:41 ` Heiko Carstens
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2023-03-21 13:41 UTC (permalink / raw)
To: Lizhe
Cc: akrowiak, pasic, jjherne, freude, gor, agordeev, borntraeger,
svens, linux-s390, linux-kernel
On Sun, Mar 19, 2023 at 12:19:41PM +0800, Lizhe wrote:
> If there is no driver match function, the driver core assumes that each
> candidate pair (driver, device) matches, see driver_match_device().
>
> Drop the matrix bus's match function that always returned 1 and so
> implements the same behaviour as when there is no match function
>
> Signed-off-by: Lizhe <sensor1010@163.com>
> ---
> drivers/s390/crypto/vfio_ap_drv.c | 6 ------
> 1 file changed, 6 deletions(-)
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-21 13:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-19 4:19 [PATCH v1] s390/vfio-ap-drv: Remove redundant driver match function Lizhe
2023-03-20 14:47 ` Anthony Krowiak
2023-03-21 13:41 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox