From: Sean Christopherson <seanjc@google.com>
To: Pawan Gupta <pawan.kumar.gupta@linux.intel.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Emanuele Giuseppe Esposito <eesposit@redhat.com>,
kvm@vger.kernel.org, Jim Mattson <jmattson@google.com>,
Ben Serebrin <serebrin@google.com>,
Peter Shier <pshier@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Maxim Levitsky <mlevitsk@redhat.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] kvm: vmx: Add IA32_FLUSH_CMD guest support
Date: Tue, 21 Mar 2023 16:59:08 -0700 [thread overview]
Message-ID: <ZBpEzGxB6XzpVMF4@google.com> (raw)
In-Reply-To: <ZBhzhPDk+EV1zRf0@google.com>
On Mon, Mar 20, 2023, Sean Christopherson wrote:
> On Fri, Mar 17, 2023, Pawan Gupta wrote:
> > Thats what I think, and if its too late to be squashed I will send a
> > formal patch. Maintainers?
>
> Honestly, I'd rather revert the whole mess and try again. The patches obviously
> weren't tested, and the entire approach (that was borrowed from the existing
> MSR_IA32_PRED_CMD code) makes no sense.
Yeah, revert incoming. This is just the tip of the iceberg. SVM completely drops
the error, which is why there are no boot failures on AMD despite having the same
broken logic. Neither SVM nor VMX marks the MSR as being passthrough friendly and
thus breaks MSR filtering.
next prev parent reply other threads:[~2023-03-21 23:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 13:29 [PATCH 0/3] KVM: support the cpu feature FLUSH_L1D Emanuele Giuseppe Esposito
2023-02-01 13:29 ` [PATCH 1/3] kvm: vmx: Add IA32_FLUSH_CMD guest support Emanuele Giuseppe Esposito
2023-03-17 19:04 ` Nathan Chancellor
2023-03-17 22:53 ` Pawan Gupta
2023-03-17 23:14 ` Nathan Chancellor
2023-03-17 23:59 ` Pawan Gupta
2023-03-20 14:53 ` Sean Christopherson
2023-03-20 15:40 ` Emanuele Giuseppe Esposito
2023-03-20 16:24 ` Sean Christopherson
2023-03-20 16:48 ` Emanuele Giuseppe Esposito
2023-03-21 23:59 ` Sean Christopherson [this message]
2023-02-01 13:29 ` [PATCH 2/3] kvm: svm: " Emanuele Giuseppe Esposito
2023-02-01 13:29 ` [PATCH 3/3] kvm: x86: Advertise FLUSH_L1D to user space Emanuele Giuseppe Esposito
2023-03-14 13:29 ` [PATCH 0/3] KVM: support the cpu feature FLUSH_L1D Paolo Bonzini
2023-03-20 16:52 ` Jim Mattson
2023-03-21 8:40 ` Emanuele Giuseppe Esposito
2023-03-21 9:43 ` Paolo Bonzini
2023-03-21 18:30 ` Jim Mattson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBpEzGxB6XzpVMF4@google.com \
--to=seanjc@google.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=eesposit@redhat.com \
--cc=hpa@zytor.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=nathan@kernel.org \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=pbonzini@redhat.com \
--cc=pshier@google.com \
--cc=serebrin@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox