From: Juri Lelli <juri.lelli@redhat.com>
To: Dietmar Eggemann <dietmar.eggemann@arm.com>
Cc: Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Waiman Long <longman@redhat.com>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Johannes Weiner <hannes@cmpxchg.org>, Hao Luo <haoluo@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Luca Abeni <luca.abeni@santannapisa.it>,
Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
Qais Yousef <qyousef@layalina.io>, Wei Wang <wvw@google.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] sched/cpuset: Fix DL BW accounting in case can_attach() fails
Date: Thu, 23 Mar 2023 10:33:22 +0100 [thread overview]
Message-ID: <ZBwc4l0ZyyRQPiSP@localhost.localdomain> (raw)
In-Reply-To: <20230322135959.1998790-1-dietmar.eggemann@arm.com>
Hi,
On 22/03/23 14:59, Dietmar Eggemann wrote:
> I followed Longman's idea to add a `deadline task transfer count` into
> cpuset and only update the `dl task count` in cpuset_attach().
>
> Moreover, I switched from per-task DL BW request to a per-cpuset one.
> This way we don't have to free per-task in case xxx_can_attach() fails.
>
> The DL BW freeing is handled in cpuset_cancel_attach() for the case
> `multiple controllers and one of the non-cpuset can_attach() fails`.
>
> Only lightly tested on cgroup v1 with exclusive cpusets so far.
This makes sense to me. Thanks for working on it!
Guess I might incorporate these in my (RFC) series and re-post the whole
lot?
Best,
Juri
next prev parent reply other threads:[~2023-03-23 9:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 13:59 [RFC PATCH 0/2] sched/cpuset: Fix DL BW accounting in case can_attach() fails Dietmar Eggemann
2023-03-22 13:59 ` [RFC PATCH 1/2] sched/deadline: Create DL BW alloc, free & check overflow interface Dietmar Eggemann
2023-03-22 13:59 ` [RFC PATCH 2/2] cgroup/cpuset: Free DL BW in case can_attach() fails Dietmar Eggemann
2023-03-22 14:48 ` Waiman Long
2023-03-23 9:33 ` Juri Lelli [this message]
2023-03-24 14:56 ` [RFC PATCH 0/2] sched/cpuset: Fix DL BW accounting " Dietmar Eggemann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBwc4l0ZyyRQPiSP@localhost.localdomain \
--to=juri.lelli@redhat.com \
--cc=bristot@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=dietmar.eggemann@arm.com \
--cc=hannes@cmpxchg.org \
--cc=haoluo@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=longman@redhat.com \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=qyousef@layalina.io \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=wvw@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox